From 7f208b4bde8a871d11b8d2a5264150b713cf0f00 Mon Sep 17 00:00:00 2001 From: rigelrozanski Date: Fri, 26 Jul 2019 14:36:29 -0400 Subject: [PATCH 1/4] panic on non-registered store --- store/cachemulti/store.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/store/cachemulti/store.go b/store/cachemulti/store.go index 4ac54ce07780..3dbc72408f67 100644 --- a/store/cachemulti/store.go +++ b/store/cachemulti/store.go @@ -1,6 +1,7 @@ package cachemulti import ( + "fmt" "io" dbm "github.com/tendermint/tendermint/libs/db" @@ -140,5 +141,9 @@ func (cms Store) GetStore(key types.StoreKey) types.Store { // GetKVStore returns an underlying KVStore by key. func (cms Store) GetKVStore(key types.StoreKey) types.KVStore { - return cms.stores[key].(types.KVStore) + store := cms.stores[key] + if key == nil { + panic(fmt.Sprintf("kv store with key %v has not been registered in stores", key)) + } + return store.(types.KVStore) } From 47f80f9f8e91ab32a37ad3f6cc8c5b68f1f2692b Mon Sep 17 00:00:00 2001 From: Federico Kunze Date: Mon, 29 Jul 2019 14:52:52 +0200 Subject: [PATCH 2/4] add pending --- .pending/improvements/store/_4792-panic-non-regi | 1 + 1 file changed, 1 insertion(+) create mode 100644 .pending/improvements/store/_4792-panic-non-regi diff --git a/.pending/improvements/store/_4792-panic-non-regi b/.pending/improvements/store/_4792-panic-non-regi new file mode 100644 index 000000000000..1a83162fa19a --- /dev/null +++ b/.pending/improvements/store/_4792-panic-non-regi @@ -0,0 +1 @@ +#4792 panic on non-registered store \ No newline at end of file From a4ce1386e96e0737b446ff6d2492be7bc31d49ef Mon Sep 17 00:00:00 2001 From: rigelrozanski Date: Mon, 29 Jul 2019 13:16:52 -0400 Subject: [PATCH 3/4] cl --- .pending/improvements/store/_4792-bpanic-on-retr | 1 + go.mod | 1 + go.sum | 2 ++ 3 files changed, 4 insertions(+) create mode 100644 .pending/improvements/store/_4792-bpanic-on-retr diff --git a/.pending/improvements/store/_4792-bpanic-on-retr b/.pending/improvements/store/_4792-bpanic-on-retr new file mode 100644 index 000000000000..b5e233bbb3d5 --- /dev/null +++ b/.pending/improvements/store/_4792-bpanic-on-retr @@ -0,0 +1 @@ +#4792 bpanic on retrieval of unregistered store \ No newline at end of file diff --git a/go.mod b/go.mod index dab8b81245b4..54efc7b9103d 100644 --- a/go.mod +++ b/go.mod @@ -6,6 +6,7 @@ require ( github.com/btcsuite/btcd v0.0.0-20190115013929-ed77733ec07d github.com/cosmos/go-bip39 v0.0.0-20180618194314-52158e4697b8 github.com/cosmos/ledger-cosmos-go v0.10.3 + github.com/cosmos/tools/cmd/clog v0.0.0-20190722180430-ea942c183cba // indirect github.com/fortytw2/leaktest v1.3.0 // indirect github.com/gogo/protobuf v1.2.1 github.com/golang/mock v1.3.1-0.20190508161146-9fa652df1129 diff --git a/go.sum b/go.sum index 9769a861da51..1706de1199b2 100644 --- a/go.sum +++ b/go.sum @@ -33,6 +33,8 @@ github.com/cosmos/ledger-cosmos-go v0.10.3 h1:Qhi5yTR5Pg1CaTpd00pxlGwNl4sFRdtK1J github.com/cosmos/ledger-cosmos-go v0.10.3/go.mod h1:J8//BsAGTo3OC/vDLjMRFLW6q0WAaXvHnVc7ZmE8iUY= github.com/cosmos/ledger-go v0.9.2 h1:Nnao/dLwaVTk1Q5U9THldpUMMXU94BOTWPddSmVB6pI= github.com/cosmos/ledger-go v0.9.2/go.mod h1:oZJ2hHAZROdlHiwTg4t7kP+GKIIkBT+o6c9QWFanOyI= +github.com/cosmos/tools/cmd/clog v0.0.0-20190722180430-ea942c183cba h1:YhVnGzBkE2TvfBW5fAYBdNVK/3bwTPYVbMaOIGRHFRY= +github.com/cosmos/tools/cmd/clog v0.0.0-20190722180430-ea942c183cba/go.mod h1:TdPuAVaU2rc6K24ejr/AnGznt9Fd2qjtMoRrTO4uFrI= github.com/cpuguy83/go-md2man v1.0.10/go.mod h1:SmD6nW6nTyfqj6ABTjUi3V3JVMnlJmwcJI5acqYI6dE= github.com/davecgh/go-spew v0.0.0-20171005155431-ecdeabc65495/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= From d5725ecb5ed90b370245cbda469338a7da8f910d Mon Sep 17 00:00:00 2001 From: frog power 4000 Date: Mon, 29 Jul 2019 13:17:56 -0400 Subject: [PATCH 4/4] Delete _4792-bpanic-on-retr --- .pending/improvements/store/_4792-bpanic-on-retr | 1 - 1 file changed, 1 deletion(-) delete mode 100644 .pending/improvements/store/_4792-bpanic-on-retr diff --git a/.pending/improvements/store/_4792-bpanic-on-retr b/.pending/improvements/store/_4792-bpanic-on-retr deleted file mode 100644 index b5e233bbb3d5..000000000000 --- a/.pending/improvements/store/_4792-bpanic-on-retr +++ /dev/null @@ -1 +0,0 @@ -#4792 bpanic on retrieval of unregistered store \ No newline at end of file