Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chainID strictness check from 02-client UpgradeChain proposal handler to ValidateBasic #1310

Open
1 of 4 tasks
colin-axner opened this issue Apr 28, 2022 · 0 comments
Open
1 of 4 tasks

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Apr 28, 2022

Summary

Pre-requirement:

Move the switch case added in #1309 to a check in message ValidateBasic on a proposal submission for UpgradeChain (so that we perform this check long before the proposal would pass). We must migrate from x/gov v1beta1 to x/gov v1 first.

The current behaviour will perform the check after the proposal passes, but ideally we would immediately reject any proposal which uses a bad chainID to upgrade to. v1beta1 does not support this as we need the context to determine if the next chainID makes sense.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega changed the title Move chainID strictness check from 02-client UpgradeChain proposal handler to sdk middleware Move chainID strictness check from 02-client UpgradeChain proposal handler to ValidateBasic Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo 🏃
Development

No branches or pull requests

1 participant