Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mock stack in callbacks ibc_middleware_test.go #4328

Open
3 tasks
colin-axner opened this issue Aug 10, 2023 · 0 comments
Open
3 tasks

Use mock stack in callbacks ibc_middleware_test.go #4328

colin-axner opened this issue Aug 10, 2023 · 0 comments
Labels
callbacks middleware Issues for callbacks middleware icebox Issues that we will not address for the time being nice-to-have

Comments

@colin-axner
Copy link
Contributor

Summary

Use the mock stack in callbacks ibc_middleware_test.go instead of the transfer stack. This allows for more predictable maintenance of the unit tests. Currently it isn't possible as the mock would need to define its own packet data type which implements the GetSender function. When that functionality is added, the tests can be rewritten to use the mock stack instead of transfer, thus simplifying logic


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added nice-to-have icebox Issues that we will not address for the time being callbacks middleware Issues for callbacks middleware labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callbacks middleware Issues for callbacks middleware icebox Issues that we will not address for the time being nice-to-have
Projects
Status: No status
Development

No branches or pull requests

1 participant