Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move legacySubspace key table initialisation to migration code #4670

Closed
3 tasks
damiannolan opened this issue Sep 15, 2023 · 0 comments · Fixed by #4730
Closed
3 tasks

Move legacySubspace key table initialisation to migration code #4670

damiannolan opened this issue Sep 15, 2023 · 0 comments · Fixed by #4730
Assignees
@charleenfei
Labels
e2e type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v8.0.0

Comments

@damiannolan
Copy link
Member

Summary

Move keyTable initialisation for legacySubspace params to the migration handler code which performs the upgrade to self contained params.

Ensure the e2e upgrade test for v8 is re-run as a regression.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added type: code hygiene Clean up code but without changing functionality or interfaces e2e v8 labels Sep 15, 2023
@damiannolan damiannolan added this to the v8.0.0 milestone Sep 15, 2023
@charleenfei charleenfei self-assigned this Sep 19, 2023
@charleenfei charleenfei mentioned this issue Sep 20, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
e2e type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

move legacy keytable init to migration handler code cosmos/ibc-go
2 participants
@damiannolan @charleenfei