From 7310cb02c3e3d525c18d987fc2b2dc8e482a23e1 Mon Sep 17 00:00:00 2001 From: Alexey Pustovalov Date: Sat, 13 Nov 2021 02:27:21 +0200 Subject: [PATCH] Changed base Windows image for build --- .github/workflows/images_build_windows.yml | 2 +- Dockerfiles/build-base/windows/Dockerfile.agent | 7 +++++-- Dockerfiles/build-base/windows/Dockerfile.agent2 | 11 +++++++---- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/.github/workflows/images_build_windows.yml b/.github/workflows/images_build_windows.yml index 48f90c8d2a..719b49f6c4 100644 --- a/.github/workflows/images_build_windows.yml +++ b/.github/workflows/images_build_windows.yml @@ -137,7 +137,7 @@ jobs: echo "docker build --file=$dockerfile $tags $context" docker build --label org.opencontainers.image.revision=${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.revision'] }} ` --label org.opencontainers.image.created=${{ fromJSON(steps.meta.outputs.json).labels['org.opencontainers.image.created'] }} ` - --build-arg=BUILD_BASE_IMAGE=mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-${{ steps.base_os_tag.outputs.os_tag }} ` + --build-arg=BUILD_BASE_IMAGE=mcr.microsoft.com/windows/servercore:${{ steps.base_os_tag.outputs.os_tag }} ` --file=$dockerfile ` $tags ` $context diff --git a/Dockerfiles/build-base/windows/Dockerfile.agent b/Dockerfiles/build-base/windows/Dockerfile.agent index abf0e75a0f..004da6b8bd 100644 --- a/Dockerfiles/build-base/windows/Dockerfile.agent +++ b/Dockerfiles/build-base/windows/Dockerfile.agent @@ -1,6 +1,6 @@ # syntax=docker/dockerfile:1 # escape=` -ARG BUILD_BASE_IMAGE=mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2022 +ARG BUILD_BASE_IMAGE=mcr.microsoft.com/windows/servercore:ltsc2022 FROM $BUILD_BASE_IMAGE ARG PCRE_VERSION=8.45 @@ -118,8 +118,11 @@ RUN Set-Location -Path $env:SystemDrive\.; ` --quiet ` --wait ` --norestart ` - --nocache modify ` + --nocache ` --installPath """${env:ProgramFiles(x86)}\Microsoft Visual Studio\2019\BuildTools""" ` + --channelUri https://aka.ms/vs/16/release/channel ` + --installChannelUri https://aka.ms/vs/16/release/channel ` + --channelId VisualStudio.16.Release ` # https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2019 --add Microsoft.VisualStudio.Component.Windows10SDK.19041 ` --add Microsoft.VisualStudio.Component.VC.CMake.Project; ` diff --git a/Dockerfiles/build-base/windows/Dockerfile.agent2 b/Dockerfiles/build-base/windows/Dockerfile.agent2 index cada9d08c2..a9390dfc36 100644 --- a/Dockerfiles/build-base/windows/Dockerfile.agent2 +++ b/Dockerfiles/build-base/windows/Dockerfile.agent2 @@ -1,12 +1,12 @@ # syntax=docker/dockerfile:1 # escape=` -ARG BUILD_BASE_IMAGE=mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2022 +ARG BUILD_BASE_IMAGE=mcr.microsoft.com/windows/servercore:ltsc2022 FROM $BUILD_BASE_IMAGE as builder_base ARG PCRE_VERSION=8.45 ARG OPENSSL_VERSION=1.1.1l ARG ZLIB_VERSION=1.2.11 -ARG GOLANG_VERSION=1.17.2 +ARG GOLANG_VERSION=1.17.3 ARG SEVEN_ZIP_VERSION=1900 ARG BUILD_ARCH=x64 ARG CPU_MODEL=AMD64 @@ -67,7 +67,7 @@ RUN Set-Location -Path $env:SystemDrive\.; ` Write-Host ('Downloading {0} ...' -f $env:GOLANG_URL); ` [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; ` Invoke-WebRequest -OutFile $env:SystemDrive\go-amd64.msi -Uri $env:GOLANG_URL; ` - $sha256 = 'f7d54883e9bb653b1a50061a7fa42a6503c680a25cee32f16ccba51a77b0c83b'; ` + $sha256 = 'bf3c475726c9165eb5d809e1bb4ce33550a25850495aac0a5df6d0df05930936'; ` ` Write-Host ('Verifying SHA256 ({0}) ...' -f $sha256); ` if ((Get-FileHash $env:SystemDrive\go-amd64.msi -Algorithm sha256).Hash -ne $sha256) { ` @@ -141,8 +141,11 @@ RUN Set-Location -Path $env:SystemDrive\.; ` --quiet ` --wait ` --norestart ` - --nocache modify ` + --nocache ` --installPath """${env:ProgramFiles(x86)}\Microsoft Visual Studio\2019\BuildTools""" ` + --channelUri https://aka.ms/vs/16/release/channel ` + --installChannelUri https://aka.ms/vs/16/release/channel ` + --channelId VisualStudio.16.Release ` # https://docs.microsoft.com/en-us/visualstudio/install/workload-component-id-vs-build-tools?view=vs-2019 --add Microsoft.VisualStudio.Component.Windows10SDK.19041 ` --add Microsoft.VisualStudio.Component.VC.CMake.Project; `