You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that there are mismatches in the default constructors of various Packet subclasses (e.g., DetectionVectorPacket, ImageFramePacket, etc.) between this project and MediaPipeUnityPlugin. In MediaPipeUnityPlugin, the default constructors call the base(true) base constructor, while the constructors in this project call base().
Any particular reason on calling a different base constructor? If there is not any, can you please update default constructors of all Packet subclasses to call base(true) instead? Without base(true), native pointer to Packet is never assigned.
MediaPipe.NET was based off an earlier version of MediaPipeUnity, so things may have changed quite a bit. As for the other discrepancies like mismatching classes, I'll go ahead and fix them right now.
Thank you for porting this library from MediaPipeUnityPlugin. Wonderful work.
I noticed that there are mismatches in the default constructors of various
Packet
subclasses (e.g.,DetectionVectorPacket
,ImageFramePacket
, etc.) between this project and MediaPipeUnityPlugin. In MediaPipeUnityPlugin, the default constructors call thebase(true)
base constructor, while the constructors in this project callbase()
.Using
DetectionVectorPacket
as example. The MediaPipeUnityPlugin project has the following.https://github.com/homuler/MediaPipeUnityPlugin/blob/v0.9.1/Packages/com.github.homuler.mediapipe/Runtime/Scripts/Framework/Packet/DetectionVectorPacket.cs#L17
And
DetectionVectorPacket
in this project has the following.https://github.com/vignetteapp/MediaPipe.NET/blob/176415561c442cce8e92d1cde59b875e6a14995a/Mediapipe.Net/Framework/Packets/DetectionVectorPacket.cs#L15
Any particular reason on calling a different base constructor? If there is not any, can you please update default constructors of all
Packet
subclasses to callbase(true)
instead? Withoutbase(true)
, native pointer toPacket
is never assigned.https://github.com/vignetteapp/MediaPipe.NET/blob/176415561c442cce8e92d1cde59b875e6a14995a/Mediapipe.Net/Framework/Packets/Packet.cs#L16-L26
Also, if it is not too much trouble, I would really appreciate if you can upload new NuGet packages with this change. Thank you so much.
The text was updated successfully, but these errors were encountered: