Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support environment variables syntax in settings (Craft 3.1) #35

Closed
timkelty opened this issue Dec 6, 2018 · 14 comments
Closed

Support environment variables syntax in settings (Craft 3.1) #35

timkelty opened this issue Dec 6, 2018 · 14 comments

Comments

@timkelty
Copy link
Contributor

timkelty commented Dec 6, 2018

craftcms/cms#3219 (comment)

The goal is to be able to use env vars for things that would change per-env…which is pretty much everything (bucket, region, keyId, secret, url)

@michaelroper
Copy link

This would probably (hopefully) solve this issue too? craftcms/cms#3531

@brandonkelly
Copy link
Member

Right, they are one and the same.

@michaelroper
Copy link

Hey @brandonkelly - I noticed that this is fixed in the 3.1 branch... doe that mean i can point Composer to use the dev-craft-3.1 version instead of the master/release package?

(I know you said you were still working on making it possible to release 3.1-only versions of plugins..)

@baileydoestech
Copy link

Would second getting the release of this now that Craft 3.1 is out (don't want our AWS secrets stored in source control), is there an ETA?

@carlcs
Copy link
Contributor

carlcs commented Jan 17, 2019

craft-3.1 branch doesn’t seem to be ready yet @michaelroper

@michaelroper
Copy link

@carlcs "craftcms/aws-s3": "dev-craft-3.1" has been working okay for me? ¯_(ツ)_/¯

@carlcs
Copy link
Contributor

carlcs commented Jan 18, 2019

@michaelroper strange, for me it’s showing the value of the env vars in the input fields after save

@michaelroper
Copy link

Do you still have settings in a config/volumes.php? Because they will override and insert themselves into the DB..

@carlcs
Copy link
Contributor

carlcs commented Jan 18, 2019

You mean „environment variables make their way into the yaml when settings are saved via web“?

craftcms/cms#3655

…thanks @michaelroper, I‘ll check tomorrow but I am pretty sure I forgot about the configuration file.

@michaelroper
Copy link

np - was just catching up on your conversation with ben in slack too... you were heading in the right direction!

@boboldehampsink
Copy link

Need this too, thanks

@andris-sevcenko
Copy link
Contributor

Just to check in, guys - going over all the plugins to see if there are any outstanding releases and/or 3.1 issues that need to be resolved is on my list.

Just still dealing with a little bit of post-3.1-crazy here.

@boboldehampsink
Copy link

Np, I just submitted some also as a reminder to myself (and that I can reference to in my own projects).

@carlcs
Copy link
Contributor

carlcs commented Feb 1, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants