Setting unknown property: craft\awss3\Volume::storageClass on dev-craft-3.1

[acehead]

Using Craft 3.1.7, project config enabled and dev-craft-3.1 version of plugin following error occurs when accessing Control panel:
Setting unknown property: craft\awss3\Volume::storageClass

[andris-sevcenko]

Can you try updating to the just-released 1.1. version of the plugin?

[acehead]

Just updated, same issue persists, it seems that https://github.com/craftcms/aws-s3/blob/1.1.0/src/Volume.php is still missing storageClass property

[andris-sevcenko]

Right, because it should have been removed by https://github.com/craftcms/aws-s3/blob/master/src/migrations/m180929_165000_remove_storageclass_setting.php

Can you check if your craft_migrations table has that migration entry? If it does, what date does it have?

[acehead]

Just checked, no such entry there. Craft says that there are migrations pending, but right after hitting the finish button I get the abovementioned error.

[andris-sevcenko]

Can you get a stack trace for that error from the log files?

[acehead]

stacktrace.txt

[andris-sevcenko]

/var/www/config/twig-webpack-extension.php seems to be calling craft\services\Globals->getSetByHandle('common').

I'm not sure that calling Craft functionality from config files is a good idea, as demonstrated by this particular issue. You're invoking Craft before it has a chance to run its migrations and this can lead to unpredictable results. Can you disable that, let the migrations run and see what happens?

[acehead]

You're absolutely right, but this was the only way we could make that happen without changing original plugin code.
Commented it out, unfortunately problem is still there, see stacktrace
stacktrace2.txt

[andris-sevcenko]

Ugh. This is not cool.

Okay. Here's the plan. Re-adding this property (since it does nothing), cutting a 1.1.1 release and for the next release require at least 1.1.1 to update and delete that property. That should ensure that everyone updates to 1.1.1, run the migration to get rid of the setting and the property is safe to be removed in the next version.

[acehead]

sounds great, waiting for 1.1.1 to be released

[andris-sevcenko]

Should be released as of now.

[acehead]

Great, worked like a charm, migration was done successfully as well. Thanks for your help!

[andris-sevcenko]

I must say, for an instant I was scared when I saw your email :)