Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint setting #67

Open
michaelhue opened this issue Sep 2, 2019 · 6 comments
Open

Add endpoint setting #67

michaelhue opened this issue Sep 2, 2019 · 6 comments

Comments

@michaelhue
Copy link

Problem

There are many storage solutions offering an S3-like API (for example fortrabbit's Object Storage or MinIO).

This plugin could be used to access those services, but currently does not offer a way to set the endpoint option available in AwsClient. Exposing the endpoint option to the Control Panel would allow users to access S3-like storage with this plugin.

Solution

Add a new Endpoint config setting.


Thank you for reading!

@michaelhue
Copy link
Author

Would you consider a pull request implementing this change?

@andris-sevcenko
Copy link
Contributor

There are a few more hurdles here. This plugin has a bunch of AWS-specific logic, too. For example here.

Honestly, the cleanest way to proceed about this would be to split this plugin into two plugins, with one being for AWS S3-like services, and the other extending the first plugin and adding on top of that. It's just a matter of finding the time for that :(

@bytebrain
Copy link

I use https://github.com/fortrabbit/craft-object-storage for S3 compatible buckets that need a custom endpoint. Works out of the box.

@mark-wff
Copy link

I need the same function! Would help me a lot to have an official plugin for it.

@ghost
Copy link

ghost commented May 15, 2020

Would like to see this added also. S3 compatible storage has become more common in my workflow.

@samthejarvis
Copy link

With the advent of services like Cloudflare R2 and other S3 compatible services, an endpoint setting will have even more utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants