Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI flag to disable pre-release-replacements #810

Open
DJDuque opened this issue Aug 6, 2024 · 2 comments
Open

CLI flag to disable pre-release-replacements #810

DJDuque opened this issue Aug 6, 2024 · 2 comments

Comments

@DJDuque
Copy link

DJDuque commented Aug 6, 2024

I read through the reference, and I think this is not currently possible, right?

It would be helpful for workflows like the one I described in #809. And given that there are already flags to disable e.g. publish, tag, etc. maybe it makes sense to have this one as well.

@epage
Copy link
Collaborator

epage commented Aug 7, 2024

Yes, cargo release is a "do everything" command and the individual "steps" are generally how we expect people to customize behavior. With cargo release tag and other commands, I'm unsure how much value add there is with a "skip replacements" flag.

@DJDuque
Copy link
Author

DJDuque commented Aug 7, 2024

This makes sense. Now that I understand how to customize the behavior with individual steps, I don't have a strong opinion about this.

On the other hand, there are already flags like --no-publish, --no-tag, --no-push (and you can also not bump the version by not specifying it). Basically we can currently skip any step except replace. Just for consistency, I think it can make sense to allow this.

It would also probably make a more intuitive experience for users to know that all steps are "equal". You can run them individually, or you can exclude them individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants