Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap goodhosts under our own administrator CLI tool #1652

Closed
guillaumerose opened this issue Nov 9, 2020 · 5 comments
Closed

Wrap goodhosts under our own administrator CLI tool #1652

guillaumerose opened this issue Nov 9, 2020 · 5 comments
Labels
status/stale Issue went stale; did not receive attention or no reply from the OP vsock

Comments

@guillaumerose
Copy link
Contributor

Currently, we compile and package goodhosts in CRC. It is slightly modified (go modules, version).
It is run as admin but it's not the only piece of code that we run as admin. We also have some shell and powershell commands that we run as admin.

The proposal is to create a new CLI tool in the code-ready organisation called admin-helper and just add the commands we need:

  • Current goodhosts features (scoped to only crc.testing domain and not more for security)
  • Add hosts file cleanup (we don't remove hosts we added in crc cleanup right now)

It will force us to maintain the admin binary more than what we currently do (we never upgraded goodhosts?).

In the "future", we could:

  • Run this tool as an admin daemon for Windows.
  • Use it for the vsock PoC to bind privileged ports.

Any thoughts?

@cfergeau
Copy link
Contributor

cfergeau commented Nov 9, 2020

Not a huge fan of hardcoding .crc.testing in many places when at the moment the crc code is mostly 'domain-independent'.
I'd add as a goal to minimize the amount of go packages which are used (apart from go standard library).

@guillaumerose
Copy link
Contributor Author

guillaumerose commented Nov 9, 2020

A good way to start could be to reuse https://github.com/code-ready/goodhosts-cli and diverge from here.

releases are already in place, etc. Maybe the CI is missing.

@gbraad
Copy link
Contributor

gbraad commented Nov 9, 2020

Not a huge fan of hardcoding .crc.testing in many places

should be provided by the metadata. so either this tool needs to have an interface to deal with this on request, or know what to use from configuration (bundle provided) as people do us SNC to create them

@guillaumerose
Copy link
Contributor Author

Related to #1328

@stale
Copy link

stale bot commented Jan 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale Issue went stale; did not receive attention or no reply from the OP vsock
Projects
None yet
Development

No branches or pull requests

3 participants