From 3f31f5b42409495f8c9e550dc957aa4709aa432a Mon Sep 17 00:00:00 2001 From: Aras Abbasi Date: Sat, 27 Jan 2024 08:24:46 +0100 Subject: [PATCH] chore: remove semver as dev dependency (#2646) --- package.json | 1 - test/http2.js | 7 +------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/package.json b/package.json index 5200f436a9b..6a923fb5b33 100644 --- a/package.json +++ b/package.json @@ -127,7 +127,6 @@ "pre-commit": "^1.2.2", "proxy": "^1.0.2", "proxyquire": "^2.1.3", - "semver": "^7.5.4", "sinon": "^17.0.1", "snazzy": "^9.0.0", "standard": "^17.0.0", diff --git a/test/http2.js b/test/http2.js index 6f5027c2269..7a183a24552 100644 --- a/test/http2.js +++ b/test/http2.js @@ -7,15 +7,11 @@ const { Blob } = require('node:buffer') const { Writable, pipeline, PassThrough, Readable } = require('node:stream') const { test, plan } = require('tap') -const { gte } = require('semver') const pem = require('https-pem') const { Client, Agent } = require('..') -const isGreaterThanv20 = gte(process.version.slice(1), '20.0.0') -// NOTE: node versions <16.14.1 have a bug which changes the order of pseudo-headers -// https://github.com/nodejs/node/pull/41735 -const hasPseudoHeadersOrderFix = gte(process.version.slice(1), '16.14.1') +const isGreaterThanv20 = process.versions.node.split('.').map(Number)[0] >= 20 plan(24) @@ -1170,7 +1166,6 @@ test('Agent should support H2 connection', async t => { test( 'Should provide pseudo-headers in proper order', - { skip: !hasPseudoHeadersOrderFix }, async t => { const server = createSecureServer(pem) server.on('stream', (stream, _headers, _flags, rawHeaders) => {