Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eosfs] delete a trash item, don't restore it #1097

Closed
butonic opened this issue Aug 17, 2020 · 1 comment · Fixed by #1099
Closed

[eosfs] delete a trash item, don't restore it #1097

butonic opened this issue Aug 17, 2020 · 1 comment · Fixed by #1099
Assignees
Labels
bug Something isn't working

Comments

@butonic
Copy link
Contributor

butonic commented Aug 17, 2020

PurgeRecycleItem should delete an entry, not restore it in

func (fs *eosfs) PurgeRecycleItem(ctx context.Context, key string) error {
u, err := getUser(ctx)
if err != nil {
return errors.Wrap(err, "storage_eos: no user in ctx")
}
uid, gid, err := fs.getUserUIDAndGID(ctx, u)
if err != nil {
return err
}
return fs.c.RestoreDeletedEntry(ctx, uid, gid, key)
}

See line 1247 above

@butonic butonic added the bug Something isn't working label Aug 17, 2020
@labkode labkode self-assigned this Aug 18, 2020
@labkode
Copy link
Member

labkode commented Aug 18, 2020

@butonic I'm on it. EOS doesn't have a functionality to purge individual files from the bin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants