Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text files are not viewable in notepad #42

Closed
jay opened this issue Jan 9, 2023 · 1 comment
Closed

Text files are not viewable in notepad #42

jay opened this issue Jan 9, 2023 · 1 comment
Labels
wontfix

Comments

@jay
Copy link
Member

jay commented Jan 9, 2023

I downloaded curl-7.87.0_1-win64-mingw.zip and the text files have LF instead of CRLF line endings and are not viewable in notepad. Here's a screenshot from a Windows 7 VM. (ignore the chinese text it's for a bug where I needed to switch locale)

Capture
@vszakats
Copy link
Member

vszakats commented Jan 9, 2023 •
edited
Loading

Windows 10 is supposed to be supporting LF EOLs, according to this: https://devblogs.microsoft.com/commandline/extended-eol-in-notepad/

Windows 7 is not supported anymore by MS. Adding these two, I made the decision that it's not worth to identify and convert everything to CRLF for the sake of old Windows systems. So far nobody complained. I think it's also a reasonable workaround to change the default text viewer to an alternative that copes with LF EOLs. Overall, I prefer not altering original/input files, unless absolutely unavoidable.

@vszakats vszakats closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2023
jay added a commit to jay/curl-for-win that referenced this issue Jan 11, 2023
@jay
_pkg.sh: convert Unix EOLs to CRLF to make Notepad happy
5ce26c9 
- Restore CRLF in README.txt, COPYING.txt, etc.

This reverts commit be6bfb2. Notepad in recent systems can properly
process LF-only lines but we're releasing a product that can run on
legacy systems where that may not be true.

Fixes curl#42
Closes #xxxx
@jay jay mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

_pkg.sh: convert Unix EOLs to CRLF to make Notepad happy jay/curl-for-win
2 participants
@jay @vszakats