Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing GIT_DIR=. from patch apply broke functionality on unix when installing dist packages #106

Closed
daften opened this issue Feb 26, 2017 · 1 comment
Closed

Removing GIT_DIR=. from patch apply broke functionality on unix when installing dist packages #106

daften opened this issue Feb 26, 2017 · 1 comment

Comments

@daften
Copy link
Contributor

daften commented Feb 26, 2017

Before I could install packages from dist and the patches would apply, since PR #104 was merged, this doesn't work. This is clearly described in the documentation:

GIT_DIR is the location of the .git folder. If this isn’t specified, Git walks up the directory tree until it gets to ~ or /, looking for a .git directory at every step.
This was referenced Feb 26, 2017
Closed
Merged
@daften
Copy link
Contributor Author

daften commented Feb 26, 2017

Two pull requests opened with two different methods. Would need to be tested on windows and it's up to the maintainter to choose the best approach. I think if #108 works on windows, that's the way to go, since dist installation will be supported then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daften