Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task matching fails silently when the cycle point does not exactly follow [scheduler]cycle point format #4843

Closed
MetRonnie opened this issue Apr 29, 2022 · 0 comments · Fixed by #4881
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Apr 29, 2022

Steps to reproduce the bug

# flow.cylc
[scheduler]
    UTC mode = True
    allow implicit tasks = True
[scheduling]
    runahead limit = P1
    initial cycle point = 2000
    [[graph]]
        P1Y = foo

(The default cycle point format is CCYYMMDDThhmmZ)

$ cylc play myflow --pause
$ cylc hold myflow//20000101T00Z  # Note the minute is not specified

The workflow log says

INFO - Command succeeded: release(['20000101T00Z/foo'])

as if it worked. And TUI shows the task as held.

But the subtle giveaway that it did not work is that you don't get

INFO - [20000101T0000Z/foo waiting(held)(runahead) job:00 flows:1] => waiting(held)

Additional context

The string match here looks like the problem.

if not match(str_cycle, cycle):
continue

I think we should try matching ISO8601Points or metomi.isodatetime.data.TimePoints (but need to take care to still match globs).

This bug does not occur for holding future cycle points

@MetRonnie MetRonnie added the bug Something is wrong :( label Apr 29, 2022
@MetRonnie MetRonnie added this to the cylc-8.0rc4 milestone Apr 29, 2022
@MetRonnie MetRonnie self-assigned this Apr 29, 2022
@MetRonnie MetRonnie mentioned this issue May 18, 2022
7 tasks
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants