Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad event handler templates bring the suite down. #2350

Closed
hjoliver opened this issue Jul 7, 2017 · 4 comments
Closed

Bad event handler templates bring the suite down. #2350

hjoliver opened this issue Jul 7, 2017 · 4 comments
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Jul 7, 2017

E.g.:

[runtime]
    [[foo]]
         script = /bin/false
         [[[events]]]
               failed handler = echo %(nam)s  # "name"!

At runtime:

...
	  File "/home/vagrant/cylc.git/lib/cylc/task_events_mgr.py", line 842, in _setup_custom_event_handlers
	    "suite_url": quote(self.suite_url),
	KeyError: 'nam'
	
2017-07-07T13:44:27+10 ERROR - error caught: cleaning up before exit
2017-07-07T13:44:27+10 INFO - Suite shutting down - ERROR: 'nam'
2017-07-07T13:44:34+10 INFO - DONE

We should catch the exception, print a warning, and carry on.

@hjoliver hjoliver added the bug Something is wrong :( label Jul 7, 2017
@hjoliver hjoliver added this to the soon milestone Jul 7, 2017
@matthewrmshin
Copy link
Contributor

I suppose we should catch this at validation?

@hjoliver
Copy link
Member Author

hjoliver commented Jul 7, 2017

That would be even better.

@matthewrmshin
Copy link
Contributor

This will have to wait until after #2349 - we need to check the settings in [[[meta]]] for a full list of keys.

@matthewrmshin
Copy link
Contributor

Fix to original issue proposed #2352. Validation to be done after #2349.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

2 participants