From c3f5e567fc47bc9bf1dfd1390df335f669a4cd28 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Fri, 4 Oct 2024 09:16:17 -0400
Subject: [PATCH 1/5] chore: Update Chrome (beta) to 130.0.6723.31 (#30362)

Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com>
---
 browser-versions.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/browser-versions.json b/browser-versions.json
index 6f04a4e6d01e..ec792b025959 100644
--- a/browser-versions.json
+++ b/browser-versions.json
@@ -1,5 +1,5 @@
 {
-  "chrome:beta": "130.0.6723.19",
+  "chrome:beta": "130.0.6723.31",
   "chrome:stable": "129.0.6668.89",
   "chrome:minimum": "64.0.3282.0"
 }

From 45de9ec2feb5868735cfadc6c62f8e20c8220592 Mon Sep 17 00:00:00 2001
From: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Date: Mon, 7 Oct 2024 10:26:50 -0500
Subject: [PATCH 2/5] chore: address some accessibility violations (#30358)

---
 .../cypress/e2e/create-from-component.cy.ts    |  4 ++--
 packages/app/cypress/e2e/specs.cy.ts           |  8 ++++----
 packages/app/src/components/FileMatch.vue      |  5 ++++-
 .../app/src/components/FileMatchInput.cy.tsx   |  2 +-
 packages/app/src/components/SpecPatterns.vue   |  1 +
 packages/app/src/runner/SnapshotControls.vue   |  1 +
 .../src/runner/SnapshotHighlightControls.vue   |  4 ++--
 .../src/runner/SpecRunnerHeaderOpenMode.vue    |  1 +
 .../selector-playground/SelectorPlayground.vue |  4 ++++
 packages/app/src/settings/SettingsSection.vue  |  2 ++
 .../settings/device/ExternalEditorSettings.vue |  9 +++++++--
 .../settings/device/NotificationSettings.vue   |  9 ++++++---
 .../settings/device/TestingPreferences.cy.tsx  |  2 +-
 .../src/settings/device/TestingPreferences.vue |  5 +++--
 packages/app/src/specs/InlineRunAllSpecs.vue   |  1 +
 .../src/components/Input.cy.tsx                |  4 ++--
 .../src/components/Select.cy.tsx               |  4 ++++
 .../frontend-shared/src/components/Select.vue  | 18 ++++++++++++++----
 .../src/components/Switch.cy.tsx               |  4 ++--
 .../frontend-shared/src/components/Switch.vue  |  4 ++--
 .../gql-components/ChooseExternalEditor.cy.tsx |  7 ++++++-
 .../gql-components/ChooseExternalEditor.vue    |  2 ++
 .../ChooseExternalEditorModal.vue              |  3 ++-
 .../modals/SelectCloudProjectModal.vue         | 12 ++++++++++--
 .../frontend-shared/src/locales/en-US.json     |  1 +
 .../launchpad/cypress/e2e/project-setup.cy.ts  |  2 +-
 packages/launchpad/src/setup/ButtonBar.vue     |  4 ++--
 .../src/setup/EnvironmentSetup.cy.tsx          |  5 ++---
 .../src/setup/SelectFrameworkOrBundler.vue     |  3 ++-
 29 files changed, 92 insertions(+), 39 deletions(-)

diff --git a/packages/app/cypress/e2e/create-from-component.cy.ts b/packages/app/cypress/e2e/create-from-component.cy.ts
index ad634e3eb803..c1710d3f23c9 100644
--- a/packages/app/cypress/e2e/create-from-component.cy.ts
+++ b/packages/app/cypress/e2e/create-from-component.cy.ts
@@ -39,7 +39,7 @@ function validateCreateFromVueComponentCard (beforeEachFn: () => void, expectedS
 
     cy.findByText('*.vue').should('be.visible')
     cy.findByText('2 matches').should('be.visible')
-    cy.findByLabelText('file-name-input').type('HelloWorld')
+    cy.findByLabelText('Search by filename').type('HelloWorld')
 
     cy.findByText('HelloWorld').should('be.visible')
     cy.findByText('1 of 2 matches').should('be.visible')
@@ -124,7 +124,7 @@ function validateCreateFromReactComponentCard (beforeEachFn: () => void, expecte
 
     cy.findByText('*.{js,jsx,tsx}').should('be.visible')
     cy.findByText('5 matches').should('be.visible')
-    cy.findByLabelText('file-name-input').type('App')
+    cy.findByLabelText('Search by filename').type('App')
 
     cy.findByText('App').should('be.visible')
     cy.findByText('1 of 5 matches').should('be.visible')
diff --git a/packages/app/cypress/e2e/specs.cy.ts b/packages/app/cypress/e2e/specs.cy.ts
index b739188438eb..8d64f17b643b 100644
--- a/packages/app/cypress/e2e/specs.cy.ts
+++ b/packages/app/cypress/e2e/specs.cy.ts
@@ -347,7 +347,7 @@ describe('App: Specs', () => {
         .and('contain', defaultMessages.createSpec.page.customPatternNoSpecs.description.split('{0}')[0])
 
         cy.findByTestId('file-match-indicator').should('contain', 'No matches')
-        cy.findByRole('button', { name: 'cypress.config.js' })
+        cy.findByRole('button', { name: 'open in IDE' })
         cy.findByTestId('spec-pattern').should('contain', 'src/**/*.{cy,spec}.{js,jsx}')
 
         cy.contains('button', defaultMessages.createSpec.updateSpecPattern)
@@ -359,7 +359,7 @@ describe('App: Specs', () => {
           o.sinon.stub(ctx.actions.file, 'openFile')
         })
 
-        cy.findByRole('button', { name: 'cypress.config.js' }).click()
+        cy.findByRole('button', { name: 'open in IDE' }).click()
 
         cy.withCtx((ctx, o) => {
           expect(ctx.actions.file.openFile).to.have.been.calledWith(o.sinon.match(new RegExp(`cypress\.config\.js$`)), 1, 1)
@@ -695,7 +695,7 @@ describe('App: Specs', () => {
         .and('contain', defaultMessages.createSpec.page.customPatternNoSpecs.description.split('{0}')[0])
 
         cy.findByTestId('file-match-indicator').should('contain', 'No matches')
-        cy.findByRole('button', { name: 'cypress.config.js' })
+        cy.findByRole('button', { name: 'open in IDE' })
         cy.findByTestId('spec-pattern').should('contain', 'src/specs-folder/*.cy.{js,jsx}')
 
         cy.contains('button', defaultMessages.createSpec.updateSpecPattern)
@@ -707,7 +707,7 @@ describe('App: Specs', () => {
           o.sinon.stub(ctx.actions.file, 'openFile')
         })
 
-        cy.findByRole('button', { name: 'cypress.config.js' }).click()
+        cy.findByRole('button', { name: 'open in IDE' }).click()
 
         cy.withCtx((ctx, o) => {
           expect(ctx.actions.file.openFile).to.have.been.calledWith(o.sinon.match(new RegExp(`cypress\.config\.js$`)), 1, 1)
diff --git a/packages/app/src/components/FileMatch.vue b/packages/app/src/components/FileMatch.vue
index 9e5c28773928..58a3b21f599c 100644
--- a/packages/app/src/components/FileMatch.vue
+++ b/packages/app/src/components/FileMatch.vue
@@ -31,6 +31,7 @@
     <div class="rounded border h-[40px] w-full inline-flex items-center hocus-default focus-within-default truncate">
       <FileMatchButton
         :expanded="expanded"
+        :aria-label="t('components.fileSearch.expandToSearchByExtensions')"
         @click="toggleExpanded()"
       >
         <span v-if="!expanded">{{ localExtensionPattern }}</span>
@@ -45,12 +46,13 @@
           v-if="expanded"
           v-model="localExtensionPattern"
           class="ml-[12px]"
+          :aria-label="t('components.fileSearch.byExtensionInput')"
           :placeholder="t('components.fileSearch.byExtensionInput')"
         />
         <FileMatchInput
           v-else
           v-model="localPattern"
-          aria-label="file-name-input"
+          aria-label="Search by filename"
           :placeholder="t('components.fileSearch.byFilenameInput')"
         />
       </div>
@@ -72,6 +74,7 @@
         <i-cy-magnifying-glass_x16 class="mr-[8px] ml-[12px] inline-block icon-light-gray-50 icon-dark-gray-500 group-focus-within:icon-light-indigo-50 group-focus-within:icon-dark-indigo-400" />
         <FileMatchInput
           v-model="localPattern"
+          :aria-label="t('components.fileSearch.byFilenameInput')"
           :placeholder="t('components.fileSearch.byFilenameInput')"
         />
       </div>
diff --git a/packages/app/src/components/FileMatchInput.cy.tsx b/packages/app/src/components/FileMatchInput.cy.tsx
index 3aa295746648..f3909c64e931 100644
--- a/packages/app/src/components/FileMatchInput.cy.tsx
+++ b/packages/app/src/components/FileMatchInput.cy.tsx
@@ -15,7 +15,7 @@ describe('<FileMatchInput />', () => {
     }
 
     cy.mount(() => (<div class="p-12">
-      <FileMatchInput modelValue={inputText.value} {...methods} />
+      <FileMatchInput aria-label="search for file" modelValue={inputText.value} {...methods} />
     </div>))
     .get('input[type=search]').should('have.value', initialText)
     .clear().type(newText)
diff --git a/packages/app/src/components/SpecPatterns.vue b/packages/app/src/components/SpecPatterns.vue
index 472aa12ec19d..d828d752cb6f 100644
--- a/packages/app/src/components/SpecPatterns.vue
+++ b/packages/app/src/components/SpecPatterns.vue
@@ -11,6 +11,7 @@
       >
         <button
           class="flex outline-transparent text-indigo-500 gap-[8px] items-center group"
+          aria-label="open in IDE"
           @click="onClick"
         >
           <i-cy-document-text_x16 class="icon-light-gray-100 icon-dark-gray-500" />
diff --git a/packages/app/src/runner/SnapshotControls.vue b/packages/app/src/runner/SnapshotControls.vue
index c4e3206a5ee8..9b76731ebdf7 100644
--- a/packages/app/src/runner/SnapshotControls.vue
+++ b/packages/app/src/runner/SnapshotControls.vue
@@ -31,6 +31,7 @@
           v-if="shouldShowStateControls || shouldShowHighlightControls"
           class="border-transparent rounded outline-none bg-gray-900 border my-1 mr-[2px] transition duration-150 hocus:border-purple-300 "
           style="padding: 3px"
+          aria-label="unpin snapshot"
           @click="unpin"
         >
           <i-cy-delete_x16
diff --git a/packages/app/src/runner/SnapshotHighlightControls.vue b/packages/app/src/runner/SnapshotHighlightControls.vue
index c0964d8a1dc9..c2f6520d02c7 100644
--- a/packages/app/src/runner/SnapshotHighlightControls.vue
+++ b/packages/app/src/runner/SnapshotHighlightControls.vue
@@ -1,13 +1,13 @@
 <template>
   <div class="rounded flex font-medium bg-gray-900 py-[2px] px-[12px] text-gray-200 text-[14px] leading-[20px] gap-[8px] items-center">
     <Switch
-      name="toggle-highlights"
+      label-id="toggle-highlights"
       :value="props.value"
       size="sm"
       @update="emits('toggle')"
     />
     <label
-      for="toggle-highlights"
+      id="toggle-highlights"
       class="cursor-pointer"
     >{{ t('runner.snapshot.highlightsLabel') }}
     </label>
diff --git a/packages/app/src/runner/SpecRunnerHeaderOpenMode.vue b/packages/app/src/runner/SpecRunnerHeaderOpenMode.vue
index 3af2d0a7606b..5c74700bf3d2 100644
--- a/packages/app/src/runner/SpecRunnerHeaderOpenMode.vue
+++ b/packages/app/src/runner/SpecRunnerHeaderOpenMode.vue
@@ -27,6 +27,7 @@
           ref="autUrlInputRef"
           :value="studioStore.needsUrl ? urlInProgress : autUrl"
           data-cy="aut-url-input"
+          aria-label="url of the application under test"
           class="flex grow mr-[12px] leading-normal max-w-full text-indigo-500 z-51 self-center hocus-link-default truncate"
           @input="setStudioUrl"
           @click="openExternally"
diff --git a/packages/app/src/runner/selector-playground/SelectorPlayground.vue b/packages/app/src/runner/selector-playground/SelectorPlayground.vue
index adefa542e3a0..f9962a04ed00 100644
--- a/packages/app/src/runner/selector-playground/SelectorPlayground.vue
+++ b/packages/app/src/runner/selector-playground/SelectorPlayground.vue
@@ -9,6 +9,7 @@
     >
       <button
         class="border rounded-md flex h-full outline-none border-gray-200 text-white transition w-[40px] duration-150 items-center justify-center hocus-default"
+        :aria-label="selectorPlaygroundStore.isEnabled ? 'click to interact with the application and build test cases' : 'click to exit interactive test building mode'"
         data-cy="playground-toggle"
         @click="toggleEnabled"
       >
@@ -64,6 +65,7 @@
           autocomplete="off"
           autocorrect="off"
           spellcheck="false"
+          aria-label="selector"
           data-cy="playground-selector"
           :style="{paddingLeft: leftOfInputText + 'ch', paddingRight: widthOfMatchesHelperText + 'px'}"
           class="border rounded-r-md font-medium h-full outline-none border-gray-200 w-full text-indigo-500 hocus-default overflow-ellipsis"
@@ -103,6 +105,7 @@
             variant="outline"
             data-cy="playground-copy"
             class="override-border"
+            aria-label="click to copy command to clipboard"
             @click="copyToClipboard"
             @focus="focus"
           >
@@ -124,6 +127,7 @@
             variant="outline"
             data-cy="playground-print"
             class="override-border"
+            aria-label="click to print command to console"
             @click="printSelected()"
             @focus="focus"
           >
diff --git a/packages/app/src/settings/SettingsSection.vue b/packages/app/src/settings/SettingsSection.vue
index a07c0eb97640..6e9e386092eb 100644
--- a/packages/app/src/settings/SettingsSection.vue
+++ b/packages/app/src/settings/SettingsSection.vue
@@ -1,6 +1,7 @@
 <template>
   <section :id="anchor">
     <h2
+      :id="labelId"
       class="font-medium text-[16px] text-gray-900 leading-[24px] inline-flex items-baseline align-middle"
     >
       <slot name="title" />
@@ -22,5 +23,6 @@
 defineProps<{
   code?: string
   anchor?: string
+  labelId?: string
 }>()
 </script>
diff --git a/packages/app/src/settings/device/ExternalEditorSettings.vue b/packages/app/src/settings/device/ExternalEditorSettings.vue
index 986d3e8a8406..40078a2d7fcb 100644
--- a/packages/app/src/settings/device/ExternalEditorSettings.vue
+++ b/packages/app/src/settings/device/ExternalEditorSettings.vue
@@ -1,6 +1,10 @@
 <template>
-  <SettingsSection>
-    <template #title>
+  <SettingsSection
+    label-id="choose-editor-label"
+  >
+    <template
+      #title
+    >
       {{ t('settingsPage.editor.title') }}
     </template>
     <template #description>
@@ -10,6 +14,7 @@
     <ChooseExternalEditor
       v-if="props.gql.localSettings"
       :gql="props.gql"
+      label-id="choose-editor-label"
       @chose-editor="handleChoseEditor"
     />
   </SettingsSection>
diff --git a/packages/app/src/settings/device/NotificationSettings.vue b/packages/app/src/settings/device/NotificationSettings.vue
index 8b415ac727ca..e0c9a2877a36 100644
--- a/packages/app/src/settings/device/NotificationSettings.vue
+++ b/packages/app/src/settings/device/NotificationSettings.vue
@@ -32,16 +32,17 @@
 
       <div class="px-[16px] divide-y divide-gray-50">
         <div
-          v-for="({id, title}) in switches"
+          v-for="({id, labelId, title}) in switches"
           :key="id"
           class="py-[16px]"
         >
           <h4 class="flex text-gray-800 text-[16px] leading-[24px] items-center">
-            <label :for="id">{{ title }}</label>
+            <label :id="labelId">{{ title }}</label>
             <Switch
+              :id="id"
               class="mx-[8px]"
               :value="props.gql.localSettings.preferences[id] ?? false"
-              :name="id"
+              :label-id="labelId"
               :disabled="!desktopNotificationsEnabled"
               @update="(value) => updatePref(id, value)"
             />
@@ -149,10 +150,12 @@ mutation NotificationSettings_ShowNotification($title: String!, $body: String!)
 const switches = [
   {
     id: 'notifyWhenRunStarts',
+    labelId: 'notifyWhenRunStartsLabel',
     title: t('settingsPage.notifications.notifyMeWhenRunStarts'),
   },
   {
     id: 'notifyWhenRunStartsFailing',
+    labelId: 'notifyWhenRunStartsFailingLabel',
     title: t('settingsPage.notifications.notifyMeWhenRunIsFailing'),
   },
 ]
diff --git a/packages/app/src/settings/device/TestingPreferences.cy.tsx b/packages/app/src/settings/device/TestingPreferences.cy.tsx
index f82896a8b3e6..2368059bc564 100644
--- a/packages/app/src/settings/device/TestingPreferences.cy.tsx
+++ b/packages/app/src/settings/device/TestingPreferences.cy.tsx
@@ -28,7 +28,7 @@ describe('<TestingPreferences />', () => {
       </div>),
     })
 
-    cy.get(`#autoScrollingEnabled[role="switch"]`)
+    cy.get(`#autoScrollingToggle[role="switch"]`)
     .should('have.attr', 'aria-checked', 'false')
   })
 })
diff --git a/packages/app/src/settings/device/TestingPreferences.vue b/packages/app/src/settings/device/TestingPreferences.vue
index 70c8fde48b35..b5166c1a855a 100644
--- a/packages/app/src/settings/device/TestingPreferences.vue
+++ b/packages/app/src/settings/device/TestingPreferences.vue
@@ -11,11 +11,12 @@
     >
       <div class="py-[16px]">
         <h4 class="flex text-gray-800 text-[16px] leading-[24px] items-center">
-          <label :for="autoScrollingPreference.id">{{ autoScrollingPreference.title }}</label>
+          <label :id="autoScrollingPreference.id">{{ autoScrollingPreference.title }}</label>
           <Switch
+            id="autoScrollingToggle"
             class="mx-[8px]"
             :value="props.gql.localSettings.preferences[autoScrollingPreference.id] ?? false"
-            :name="autoScrollingPreference.id"
+            :label-id="autoScrollingPreference.id"
             @update="(value) => updatePref(value)"
           />
         </h4>
diff --git a/packages/app/src/specs/InlineRunAllSpecs.vue b/packages/app/src/specs/InlineRunAllSpecs.vue
index a6c313e024f9..ad673bfe36ef 100644
--- a/packages/app/src/specs/InlineRunAllSpecs.vue
+++ b/packages/app/src/specs/InlineRunAllSpecs.vue
@@ -6,6 +6,7 @@
     <button
       class="flex h-full w-full items-center justify-center"
       data-cy="run-all-specs-button"
+      :aria-label="t('specPage.runSelectedSpecs', specNumber)"
       :disabled="specNumber === 0"
       @click.stop="emits('runAllSpecs')"
     >
diff --git a/packages/frontend-shared/src/components/Input.cy.tsx b/packages/frontend-shared/src/components/Input.cy.tsx
index 39f5d623e490..107884c1ab67 100644
--- a/packages/frontend-shared/src/components/Input.cy.tsx
+++ b/packages/frontend-shared/src/components/Input.cy.tsx
@@ -9,7 +9,7 @@ describe('<Input/>', { viewportWidth: 400, viewportHeight: 80 }, () => {
     const textToType = 'My wonderful input text'
 
     // @ts-ignore = vModel is v-model in vue
-    cy.mount(() => <Input vModel={value.value}/>)
+    cy.mount(() => <Input vModel={value.value} aria-label="status"/>)
     cy.get('input').type(textToType, { delay: 0 })
 
     cy.should(() => {
@@ -40,7 +40,7 @@ describe('<Input/>', { viewportWidth: 400, viewportHeight: 80 }, () => {
     const value = ref('')
 
     // @ts-ignore = vModel is v-model in vue
-    cy.mount(() => <Input vModel={value.value}/>)
+    cy.mount(() => <Input vModel={value.value} aria-label="status"/>)
     cy.get('input').should('have.attr', 'autocomplete', 'off')
   })
 })
diff --git a/packages/frontend-shared/src/components/Select.cy.tsx b/packages/frontend-shared/src/components/Select.cy.tsx
index f7beb3b84d0e..865b5c7e0200 100644
--- a/packages/frontend-shared/src/components/Select.cy.tsx
+++ b/packages/frontend-shared/src/components/Select.cy.tsx
@@ -35,9 +35,11 @@ const mountSelect = (props: any = {}) => {
   // a click on the body dismisses the options
   return cy.mount(() => (
     <div class="p-12 w-[300px]">
+      <label id="mock-label">Mock Label</label>
       <Select
         options={defaultOptions}
         modelValue={value}
+        labelId="mock-label"
         {...props}
         v-slots={props.vSlots}
       />
@@ -165,6 +167,8 @@ describe('<Select />', () => {
             'onUpdate:modelValue': (value: any) => this.model = value,
             options: defaultOptions,
             placeholder: 'A placeholder',
+            label: 'Pick a color',
+            'label-id': 'label',
           })
         },
       }).then(() => {
diff --git a/packages/frontend-shared/src/components/Select.vue b/packages/frontend-shared/src/components/Select.vue
index b0b8758cdcc9..cccab8bd6cb6 100644
--- a/packages/frontend-shared/src/components/Select.vue
+++ b/packages/frontend-shared/src/components/Select.vue
@@ -5,8 +5,13 @@
     @update:modelValue="handleUpdate"
   >
     <template #default="{ open }">
-      <ListboxLabel class="font-medium text-sm text-gray-800 block">
-        <template v-if="label">
+      <ListboxLabel
+        :id="label ? labelId : ''"
+        class="font-medium text-sm text-gray-800 block"
+      >
+        <template
+          v-if="label"
+        >
           {{ label }}
         </template>
         <slot
@@ -72,6 +77,7 @@
           leave-to-class="opacity-0"
         >
           <ListboxOptions
+            :aria-labelledby="labelId"
             class="bg-white rounded shadow-lg ring-black mt-1 text-base w-full max-h-60 ring-1 ring-opacity-5 z-10 absolute overflow-auto sm:text-sm focus:outline-none"
           >
             <ListboxOption
@@ -116,7 +122,6 @@
                     {{ get(option, itemValue || '') }}
                   </slot>
                 </span>
-
                 <span class="flex text-sm pr-3 inset-y-0 right-0 absolute items-center">
                   <slot
                     name="item-suffix"
@@ -138,7 +143,10 @@
                 </span>
               </div>
             </ListboxOption>
-            <li role="option">
+            <li
+              v-if="$slots.footer"
+              role="option"
+            >
               <slot name="footer" />
             </li>
           </ListboxOptions>
@@ -171,6 +179,7 @@ const props = withDefaults(defineProps<{
   modelValue?: Option // Current object being selected
   placeholder?: string
   label?: string
+  labelId: string
   /**
    * The value of the modelValue to render. `value` by default
    */
@@ -183,6 +192,7 @@ const props = withDefaults(defineProps<{
 }>(), {
   placeholder: '',
   label: '',
+  labelId: undefined,
   itemValue: 'value',
   modelValue: undefined,
   itemKey: 'key',
diff --git a/packages/frontend-shared/src/components/Switch.cy.tsx b/packages/frontend-shared/src/components/Switch.cy.tsx
index f832fe846119..2ffbf539ef78 100644
--- a/packages/frontend-shared/src/components/Switch.cy.tsx
+++ b/packages/frontend-shared/src/components/Switch.cy.tsx
@@ -7,13 +7,13 @@ describe('<Switch />', () => {
 
     cy.mount(() => (
       <div class="p-6">
-        <label for="test-switch">Switch</label>
+        <label id="test-switch">Switch</label>
         <Switch
           // @ts-ignore
           value={valueRef.value}
           // @ts-ignore
           onUpdate={(newVal) => (valueRef.value = newVal)}
-          name="test-switch"
+          labelId="test-switch"
         />
       </div>
     ))
diff --git a/packages/frontend-shared/src/components/Switch.vue b/packages/frontend-shared/src/components/Switch.vue
index 6aa2b079452c..77298b8bc2a4 100644
--- a/packages/frontend-shared/src/components/Switch.vue
+++ b/packages/frontend-shared/src/components/Switch.vue
@@ -1,6 +1,6 @@
 <template>
   <button
-    :id="name"
+    :aria-labelledby="labelId"
     class="border-transparent border rounded-[50px] relative hocus-default disabled:ring-0 disabled:outline-0 disabled:bg-gray-100"
     :class="[value ? 'bg-jade-400' : 'bg-gray-300', sizeClasses[size].container, {
       '!hocus:ring-0': size === 'sm'
@@ -22,7 +22,7 @@
 withDefaults(defineProps<{
   value: boolean
   size?: 'sm' | 'md' | 'lg' | 'xl'
-  name: string // required for an id so that an external <label> can be associated with the switch
+  labelId: string // required for an id so that an external <label> can be associated with the switch
   disabled?: boolean
 }>(), {
   value: false,
diff --git a/packages/frontend-shared/src/gql-components/ChooseExternalEditor.cy.tsx b/packages/frontend-shared/src/gql-components/ChooseExternalEditor.cy.tsx
index ee5f8865a3dd..0438a989f223 100644
--- a/packages/frontend-shared/src/gql-components/ChooseExternalEditor.cy.tsx
+++ b/packages/frontend-shared/src/gql-components/ChooseExternalEditor.cy.tsx
@@ -13,7 +13,12 @@ describe('ChooseExternalEditor', { viewportHeight: 400, viewportWidth: 300 }, ()
         ]
       },
       render: (gql) => {
-        return <div class="p-[16px]"><ChooseExternalEditor gql={gql} /></div>
+        return (
+          <div class="p-[16px]">
+            <label id="example-label">Mock Choose Editor</label>
+            <ChooseExternalEditor gql={gql} labelId="example-label" />
+          </div>
+        )
       },
     })
 
diff --git a/packages/frontend-shared/src/gql-components/ChooseExternalEditor.vue b/packages/frontend-shared/src/gql-components/ChooseExternalEditor.vue
index 493b65c6456d..306203ff843a 100644
--- a/packages/frontend-shared/src/gql-components/ChooseExternalEditor.vue
+++ b/packages/frontend-shared/src/gql-components/ChooseExternalEditor.vue
@@ -6,6 +6,7 @@
       :options="editorOptions"
       item-value="name"
       item-key="id"
+      :label-id="labelId"
       :placeholder="t('settingsPage.editor.noEditorSelectedPlaceholder')"
       class="w-[400px]"
       @update:model-value="updateEditor"
@@ -118,6 +119,7 @@ fragment ChooseExternalEditor on Query {
 
 const props = defineProps<{
   gql: ChooseExternalEditorFragment
+  labelId: string
 }>()
 
 const { t } = useI18n()
diff --git a/packages/frontend-shared/src/gql-components/ChooseExternalEditorModal.vue b/packages/frontend-shared/src/gql-components/ChooseExternalEditorModal.vue
index f31cc64fe0b6..f76d3dd282ca 100644
--- a/packages/frontend-shared/src/gql-components/ChooseExternalEditorModal.vue
+++ b/packages/frontend-shared/src/gql-components/ChooseExternalEditorModal.vue
@@ -15,7 +15,7 @@
       <div>
         <p class="font-normal text-sm text-gray-600 select-none">
           <slot name="description">
-            <span>{{ t("globalPage.externalEditorPreferencesDescription1") }}</span>
+            <span id="choose-editor-label">{{ t("globalPage.externalEditorPreferencesDescription1") }}</span>
           </slot>
         </p>
         <p class="font-normal text-sm text-gray-600 select-none">
@@ -36,6 +36,7 @@
       >
         <ChooseExternalEditor
           :gql="props.gql"
+          label-id="choose-editor-label"
           @chose-editor="val => preferredEditor = val ?? ''"
         />
       </div>
diff --git a/packages/frontend-shared/src/gql-components/modals/SelectCloudProjectModal.vue b/packages/frontend-shared/src/gql-components/modals/SelectCloudProjectModal.vue
index 2b8c4246e57a..3e4324a668c2 100644
--- a/packages/frontend-shared/src/gql-components/modals/SelectCloudProjectModal.vue
+++ b/packages/frontend-shared/src/gql-components/modals/SelectCloudProjectModal.vue
@@ -44,12 +44,16 @@
         :options="organizationOptions"
         item-value="name"
         item-key="id"
+        label-id="organization-label"
         :placeholder="orgPlaceholder"
         data-cy="selectOrganization"
       >
         <template #label>
           <span class="flex font-normal my-[8px] text-[16px] leading-[24px] items-end justify-between">
-            <span class="">
+            <span
+              id="organization-label"
+              class=""
+            >
               {{ t('runs.connect.modal.selectProject.organization') }}
             </span>
             <ExternalLink
@@ -76,13 +80,17 @@
         :options="projectOptions"
         item-value="name"
         item-key="id"
+        label-id="project-label"
         :disabled="!pickedOrganization"
         :placeholder="projectPlaceholder"
         data-cy="selectProject"
       >
         <template #label>
           <div class="flex font-normal text-[16px] leading-[24px] items-center justify-between">
-            <p class="text-gray-800">
+            <p
+              id="project-label"
+              class="text-gray-800"
+            >
               {{ t('runs.connect.modal.selectProject.project') }}
               <span class="text-red-500">*</span>
             </p>
diff --git a/packages/frontend-shared/src/locales/en-US.json b/packages/frontend-shared/src/locales/en-US.json
index 9436a8769730..572adb0646d4 100644
--- a/packages/frontend-shared/src/locales/en-US.json
+++ b/packages/frontend-shared/src/locales/en-US.json
@@ -13,6 +13,7 @@
       "noMatchesForFileName": "",
       "byFilenameInput": "Search by filename...",
       "byExtensionInput": "Extensions to include e.g. *.tsx, *.vue",
+      "expandToSearchByExtensions": "Search for files with extensions e.g. *.tsx, *.vue",
       "matchesIndicatorEmptyFileSearch": "No matches | 1 match | { denominator } matches",
       "matchesIndicator": "No matches | {numerator} of {denominator} matches | {numerator} of {denominator} matches"
     },
diff --git a/packages/launchpad/cypress/e2e/project-setup.cy.ts b/packages/launchpad/cypress/e2e/project-setup.cy.ts
index 4aa029b3f051..62cb67118e1f 100644
--- a/packages/launchpad/cypress/e2e/project-setup.cy.ts
+++ b/packages/launchpad/cypress/e2e/project-setup.cy.ts
@@ -507,7 +507,7 @@ describe('Launchpad: Setup Project', () => {
         cy.contains('Pick a framework').click()
         cy.findByRole('option', { name: 'Vue.js 3' }).click()
 
-        cy.findByRole('button', { name: 'Bundler Pick a bundler' }).click()
+        cy.findByRole('button', { name: 'Pick a bundler' }).click()
         cy.findByRole('option', { name: 'Vite' }).click()
 
         cy.findByRole('button', { name: 'Next step' }).should('not.have.disabled')
diff --git a/packages/launchpad/src/setup/ButtonBar.vue b/packages/launchpad/src/setup/ButtonBar.vue
index 6334cb355d51..c6d8c7719d33 100644
--- a/packages/launchpad/src/setup/ButtonBar.vue
+++ b/packages/launchpad/src/setup/ButtonBar.vue
@@ -28,7 +28,7 @@
         class="flex px-3 items-center"
       >
         <label
-          for="altFn"
+          id="altFn"
           class="px-3 text-gray-500"
           @click="handleAlt"
         >
@@ -36,7 +36,7 @@
         </label>
         <Switch
           size="lg"
-          name="altFn"
+          label-id="altFn"
           :value="altValue"
           @update="handleAlt"
         />
diff --git a/packages/launchpad/src/setup/EnvironmentSetup.cy.tsx b/packages/launchpad/src/setup/EnvironmentSetup.cy.tsx
index f5b6acb6e45d..90a95e8df228 100644
--- a/packages/launchpad/src/setup/EnvironmentSetup.cy.tsx
+++ b/packages/launchpad/src/setup/EnvironmentSetup.cy.tsx
@@ -15,7 +15,7 @@ describe('<EnvironmentSetup />', { viewportWidth: 800 }, () => {
     })
 
     cy.findByRole('button', {
-      name: 'Front-end framework Pick a framework',
+      name: 'Pick a framework',
       expanded: false,
     })
     .should('have.attr', 'aria-haspopup', 'true')
@@ -55,7 +55,7 @@ describe('<EnvironmentSetup />', { viewportWidth: 800 }, () => {
     })
 
     cy.findByRole('button', {
-      name: 'Front-end framework Pick a framework',
+      name: 'Pick a framework',
       expanded: false,
     }).click()
 
@@ -80,7 +80,6 @@ describe('<EnvironmentSetup />', { viewportWidth: 800 }, () => {
       ),
     })
 
-    cy.findByLabelText('Bundler').should('be.visible')
     cy.findByLabelText('Pick a bundler').should('be.visible')
   })
 
diff --git a/packages/launchpad/src/setup/SelectFrameworkOrBundler.vue b/packages/launchpad/src/setup/SelectFrameworkOrBundler.vue
index 3a92dea293ff..10ffc2ae0ef9 100644
--- a/packages/launchpad/src/setup/SelectFrameworkOrBundler.vue
+++ b/packages/launchpad/src/setup/SelectFrameworkOrBundler.vue
@@ -4,11 +4,12 @@
     :placeholder="props.placeholder"
     :options="props.options"
     item-key="id"
+    :label-id="props.selectorType"
     @update:model-value="selectOption"
   >
     <template #label>
       <div class="mt-[16px] mb-[8px] text-[16px] leading-[24px]">
-        <span>
+        <span :id="props.selectorType">
           {{ props.label }}
         </span>
         <span

From 0ed7de8a7c64702046b6e581db2189e18617e255 Mon Sep 17 00:00:00 2001
From: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Date: Mon, 7 Oct 2024 11:33:42 -0500
Subject: [PATCH 3/5] chore: aq results api (#30325)

* empty commit

* new workflow for a11y results

* empty commit

* Update required jobs to be a11y focused

* persist files to workspace

* restore workspace

* yarn

* .

* update

* update

* include context

* .

* translate record key

* .

* add rule check

* re-add all jobs

* cleanup

* add to the contributor pr workflkow

* rename to verify results

* ensure run is completed before fetching a11y results

* flip the logic to only track problematic rules, not passing rules

* speed up install

* ssh

* install locally

* re-add commented out jobs

* Update scripts/verify-accessibility-results.js

* pr feedback

* address pr feedback

* remove rules that were just resolved

---------

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
---
 .circleci/workflows.yml                 | 47 ++++++++++++++-
 scripts/verify-accessibility-results.js | 76 +++++++++++++++++++++++++
 2 files changed, 122 insertions(+), 1 deletion(-)
 create mode 100644 scripts/verify-accessibility-results.js

diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml
index d5785de9cef3..22aff4a1c159 100644
--- a/.circleci/workflows.yml
+++ b/.circleci/workflows.yml
@@ -1460,6 +1460,30 @@ jobs:
             PERCY_PARALLEL_NONCE=$CIRCLE_WORKFLOW_WORKSPACE_ID \
             yarn percy build:finalize || yarn percy build:finalize
 
+  # verify accessibility scores from Cypress
+  verify-accessibility-results:
+    <<: *defaults
+    resource_class: small
+    steps:
+      - run: |
+          if [[ -z MAIN_RECORD_KEY ]]; then
+            echo "skipping for contributor PRs since we don't record to the cloud"
+            circleci-agent step halt
+          fi
+      - update_known_hosts
+      - run:
+          name: checkout
+          command: git clone -b "$CIRCLE_BRANCH" "$CIRCLE_REPOSITORY_URL" --depth 1
+      - run:
+          name: Install extract-cloud-results package
+          command: |
+            npm install https://cdn.cypress.io/extract-cloud-results/v1/extract-cloud-results.tgz
+      - run:
+          name: Verify Accessibility Results
+          command: |
+            cp ./cypress/scripts/verify-accessibility-results.js verify-accessibility-results.js
+            CYPRESS_RECORD_KEY=$MAIN_RECORD_KEY node verify-accessibility-results.js
+
   ready-to-release:
     <<: *defaults
     resource_class: small
@@ -2739,6 +2763,25 @@ linux-x64-workflow: &linux-x64-workflow
           - run-reporter-component-tests-chrome
           - run-webpack-dev-server-integration-tests
           - run-vite-dev-server-integration-tests
+    # Cypress run must be completed to fetch Accessibility report
+    - verify-accessibility-results:
+        context: test-runner:cypress-record-key
+        requires:
+          - reporter-integration-tests
+          - run-app-component-tests-chrome
+          - run-app-integration-tests-chrome
+          - run-frontend-shared-component-tests-chrome
+          - run-launchpad-component-tests-chrome
+          - run-launchpad-integration-tests-chrome
+          - run-reporter-component-tests-chrome
+          - run-webpack-dev-server-integration-tests
+          - run-vite-dev-server-integration-tests
+          - driver-integration-tests-firefox
+          - driver-integration-tests-chrome
+          - driver-integration-tests-chrome-beta
+          - driver-integration-tests-electron
+          - driver-integration-tests-webkit
+          - driver-integration-memory-tests
     - lint-types:
         requires:
           - build
@@ -3074,7 +3117,9 @@ linux-x64-contributor-workflow: &linux-x64-contributor-workflow
         type: approval
         requires:
           - build
-
+    # verify-accessibility-results is required for status checks, however, it will be skipped for contributors so it
+    # can run in any order
+    - verify-accessibility-results
     - check-ts:
         requires:
           - build
diff --git a/scripts/verify-accessibility-results.js b/scripts/verify-accessibility-results.js
new file mode 100644
index 000000000000..a3ec766f796f
--- /dev/null
+++ b/scripts/verify-accessibility-results.js
@@ -0,0 +1,76 @@
+const { getAccessibilityResults } = require('@cypress/extract-cloud-results')
+
+/**
+ * The list of rules that currently have 1+ elements that have been flagged with
+ * violations within the Cypress Accessibility report that need to be addressed.
+ *
+ * For example, the `aria-required-children` rule can have multiple
+ * elements that caused this rule to fail.
+ *
+ * Once the violation is fixed in the Cypress App's Accessibility report,
+ * the fixed rule should be removed from this list.
+ *
+ * View the Accessibility report for the Cypress run in the Cloud
+ * for more details on how to address these failures.
+ */
+const rulesWithExistingViolations = [
+  'aria-required-children',
+  'aria-required-parent',
+  'image-alt',
+  'aria-allowed-role',
+  'empty-heading',
+  'heading-order',
+  'page-has-heading-one',
+  'aria-dialog-name',
+  'aria-hidden-focus',
+  'color-contrast',
+  'link-in-text-block',
+  'list',
+  'listitem',
+  'nested-interactive',
+  'scrollable-region-focusable',
+]
+
+// This polls up to 30 times every 30 seconds.
+// This resolves when the Accessibility report is ready for the Cypress run.
+getAccessibilityResults({
+  projectId: 'ypt4pf',
+})
+.then((results) => {
+  const {
+    runNumber,
+    accessibilityReportUrl,
+    summary,
+    rules,
+  } = results
+  const { total } = summary.violationCounts
+
+  console.log(`Received ${summary.isPartialReport ? 'partial' : ''} results for run #${runNumber}.`)
+  console.log(`See full report at ${accessibilityReportUrl}.`)
+
+  // write your logic to conditionally fail based on the results
+  if (total === 0) {
+    console.log('No Accessibility violations detected!')
+
+    return
+  }
+
+  const { critical, serious, moderate, minor } = summary.violationCounts
+
+  console.log(`${total} Accessibility violations were detected - ${critical} critical, ${serious} serious, ${moderate} moderate, and ${minor} minor.`)
+
+  const newRuleViolations = rules.filter((rule) => !rulesWithExistingViolations.includes(rule.name))
+
+  if (newRuleViolations.length > 0) {
+    console.error('The following rules were violated that were previously passing:')
+    console.error(newRuleViolations)
+
+    throw new Error(`${newRuleViolations.length} rule regressions were introduced and must be fixed.`)
+  }
+
+  if (total < rulesWithExistingViolations.length) {
+    console.warn(`It seems you have resolved ${rulesWithExistingViolations.length - total} rule(s). Remove them from the list of problematic rules so regressions are not introduced.`)
+  }
+
+  console.log('No new Accessibility violations detected!')
+})

From 8a8015b774dc9ce54b30bce82b6a85172d71a895 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 9 Oct 2024 11:11:23 -0400
Subject: [PATCH 4/5] chore: Update Chrome (stable) to 129.0.6668.100 (#30379)

Co-authored-by: cypress-bot[bot] <41898282+cypress-bot[bot]@users.noreply.github.com>
---
 browser-versions.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/browser-versions.json b/browser-versions.json
index ec792b025959..3bae76e92626 100644
--- a/browser-versions.json
+++ b/browser-versions.json
@@ -1,5 +1,5 @@
 {
   "chrome:beta": "130.0.6723.31",
-  "chrome:stable": "129.0.6668.89",
+  "chrome:stable": "129.0.6668.100",
   "chrome:minimum": "64.0.3282.0"
 }

From 04c1e8c90bc74ce4f736191ee73ac09c5a014867 Mon Sep 17 00:00:00 2001
From: Ryan Manuel <ryanm@cypress.io>
Date: Thu, 10 Oct 2024 09:15:40 -0500
Subject: [PATCH 5/5] fix: ensure that find-process does not error out due to a
 bad regex (#30380)

* fix: ensure that find-process does not error out due to a bad regex

* add changelog

* fix patch

* add a test

* add comment

* update comment

* blank

* blank
---
 .circleci/workflows.yml                       | 10 +--
 cli/CHANGELOG.md                              |  4 +
 .../test/unit/util/find_process_spec.ts       | 83 +++++++++++++++++++
 patches/find-process+1.4.7.patch              | 13 +++
 4 files changed, 105 insertions(+), 5 deletions(-)
 create mode 100644 packages/server/test/unit/util/find_process_spec.ts
 create mode 100644 patches/find-process+1.4.7.patch

diff --git a/.circleci/workflows.yml b/.circleci/workflows.yml
index 22aff4a1c159..d8e7037137c5 100644
--- a/.circleci/workflows.yml
+++ b/.circleci/workflows.yml
@@ -30,7 +30,7 @@ mainBuildFilters: &mainBuildFilters
         - /^release\/\d+\.\d+\.\d+$/
         # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
         - 'update-v8-snapshot-cache-on-develop'
-        - 'misc/remove_marionette_for_geckodriver'
+        - 'ryanm/fix/find-process'
         - 'publish-binary'
 
 # usually we don't build Mac app - it takes a long time
@@ -42,7 +42,7 @@ macWorkflowFilters: &darwin-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'misc/remove_marionette_for_geckodriver', << pipeline.git.branch >> ]
+    - equal: [ 'ryanm/fix/find-process', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -53,7 +53,7 @@ linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'misc/remove_marionette_for_geckodriver', << pipeline.git.branch >> ]
+    - equal: [ 'ryanm/fix/find-process', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -76,7 +76,7 @@ windowsWorkflowFilters: &windows-workflow-filters
     - equal: [ develop, << pipeline.git.branch >> ]
     # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
     - equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
-    - equal: [ 'chore/patch_windows_build', << pipeline.git.branch >> ]
+    - equal: [ 'ryanm/fix/find-process', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -152,7 +152,7 @@ commands:
           name: Set environment variable to determine whether or not to persist artifacts
           command: |
             echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
-            echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "misc/remove_marionette_for_geckodriver" ]]; then
+            echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "ryanm/fix/find-process" ]]; then
                 export SHOULD_PERSIST_ARTIFACTS=true
             fi' >> "$BASH_ENV"
   # You must run `setup_should_persist_artifacts` command and be using bash before running this command
diff --git a/cli/CHANGELOG.md b/cli/CHANGELOG.md
index 8dccb1e48bb6..50b468dd75ca 100644
--- a/cli/CHANGELOG.md
+++ b/cli/CHANGELOG.md
@@ -3,6 +3,10 @@
 
 _Released 10/1/2024 (PENDING)_
 
+**Bugfixes:**
+
+- Patched [find-process](https://github.com/yibn2008/find-process) to fix an issue where trying to clean up browser profiles can throw an error on Windows. Addresses [#30378](https://github.com/cypress-io/cypress/issues/30378).
+
 **Misc:**
 
 - Cypress now consumes [geckodriver](https://firefox-source-docs.mozilla.org/testing/geckodriver/index.html) to help automate the Firefox browser instead of [marionette-client](https://github.com/cypress-io/marionette-client). Addresses [#30217](https://github.com/cypress-io/cypress/issues/30217).
diff --git a/packages/server/test/unit/util/find_process_spec.ts b/packages/server/test/unit/util/find_process_spec.ts
new file mode 100644
index 000000000000..b87aa55f6a0b
--- /dev/null
+++ b/packages/server/test/unit/util/find_process_spec.ts
@@ -0,0 +1,83 @@
+import utils from 'find-process/lib/utils'
+import { sinon } from '../../spec_helper'
+import { byPid } from '../../../lib/util/find_process'
+
+describe('lib/util/find_process', function () {
+  // This is testing the patch for find-process to handle windows processes that have a mixture of carriage returns
+  it('does not crash in windows with processes that deal with a mixture of carriage returns', async () => {
+    sinon.stub(process, 'platform').value('win32')
+    // Create a table that matches what 'Get-CimInstance -className win32_process | select Name,ProcessId,ParentProcessId,CommandLine,ExecutablePath' does in powershell
+    const process1 = 'Name : abc\r\nProcessId : 123\r\nParentProcessId : 456\r\nCommandLine : "c:\\path\\to\\abc.exe"\r\nExecutablePath : c:\\path\\to\\abc.exe'
+    const process2 = 'Name : xyz\r\nProcessId : 789\r\nParentProcessId : 1011\r\nCommandLine : "c:\\path\\to\\xyz.exe"\r\nExecutablePath : c:\\path\\to\\xyz.exe'
+    const process3 = 'Name : def\r\nProcessId : 1213\r\nParentProcessId : 1415\r\nCommandLine : "c:\\path\\to\\def.exe"\r\nExecutablePath : c:\\path\\to\\def.exe'
+    const process4 = 'Name : ghi\r\nProcessId : 1617\r\nParentProcessId : 1819\r\nCommandLine : "c:\\path\\to\\ghi.exe"\r\nExecutablePath : c:\\path\\to\\ghi.exe'
+    const process5 = 'Name : jkl\r\nProcessId : 2021\r\nParentProcessId : 2223\r\nCommandLine : "c:\\path\\to\\jkl.exe"\r\nExecutablePath : c:\\path\\to\\jkl.exe'
+    // Include all of this regex: (\r\n\r\n|\r\n\n|\n\r\n|\n\n)
+    const returnString = `${process1}\r\n\r\n${process2}\r\n\n${process3}\n\r\n${process4}\n\n${process5}`
+
+    sinon.stub(utils, 'spawn').returns({
+      stdout: {
+        on: (event: string, callback: (data: string) => void) => {
+          if (event === 'data') {
+            callback(returnString)
+          }
+        },
+      },
+      on: (event: string, callback: (code: number) => void) => {
+        if (event === 'close') {
+          callback(0)
+        }
+      },
+    })
+
+    const result1 = await byPid(123)
+
+    expect(result1).to.eql([{
+      pid: 123,
+      ppid: 456,
+      name: 'abc',
+      cmd: '"c:\\path\\to\\abc.exe"',
+      bin: 'c:\\path\\to\\abc.exe',
+    }])
+
+    const result2 = await byPid(789)
+
+    expect(result2).to.eql([{
+      pid: 789,
+      ppid: 1011,
+      name: 'xyz',
+      cmd: '"c:\\path\\to\\xyz.exe"',
+      bin: 'c:\\path\\to\\xyz.exe',
+    }])
+
+    const result3 = await byPid(1213)
+
+    expect(result3).to.eql([{
+      pid: 1213,
+      ppid: 1415,
+      name: 'def',
+      cmd: '"c:\\path\\to\\def.exe"',
+      bin: 'c:\\path\\to\\def.exe',
+    }])
+
+    const result4 = await byPid(1617)
+
+    expect(result4).to.eql([{
+      pid: 1617,
+      ppid: 1819,
+      name: 'ghi',
+      cmd: '"c:\\path\\to\\ghi.exe"',
+      bin: 'c:\\path\\to\\ghi.exe',
+    }])
+
+    const result5 = await byPid(2021)
+
+    expect(result5).to.eql([{
+      pid: 2021,
+      ppid: 2223,
+      name: 'jkl',
+      cmd: '"c:\\path\\to\\jkl.exe"',
+      bin: 'c:\\path\\to\\jkl.exe',
+    }])
+  })
+})
diff --git a/patches/find-process+1.4.7.patch b/patches/find-process+1.4.7.patch
new file mode 100644
index 000000000000..74a0f4161282
--- /dev/null
+++ b/patches/find-process+1.4.7.patch
@@ -0,0 +1,13 @@
+diff --git a/node_modules/find-process/lib/utils.js b/node_modules/find-process/lib/utils.js
+index fb7592b..a192426 100644
+--- a/node_modules/find-process/lib/utils.js
++++ b/node_modules/find-process/lib/utils.js
+@@ -134,7 +134,7 @@ const utils = {
+    * @return {Array}
+    */
+   parseTable (data) {
+-    const lines = data.split(/(\r\n\r\n|\r\n\n|\n\r\n)|\n\n/).filter(line => {
++    const lines = data.split(/(\r\n\r\n|\r\n\n|\n\r\n|\n\n)/).filter(line => {
+       return line.trim().length > 0
+     }).map((e) => e.split(/(\r\n|\n|\r)/).filter(line => line.trim().length > 0))
+