Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyboard support for folders inside desktop GUI #3741

Closed
desfero opened this issue Mar 18, 2019 · 4 comments · Fixed by #15648
Closed

Add keyboard support for folders inside desktop GUI #3741

desfero opened this issue Mar 18, 2019 · 4 comments · Fixed by #15648
Labels
good first issue Good for newcomers pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: accessibility ♿️ Improvements for accessibility type: user experience Improvements needed for UX

Comments

@desfero
Copy link
Contributor

desfero commented Mar 18, 2019 •
edited
Loading

Current behavior:

Currently, folders are omitted during keyboard navigation in the desktop GUI because onClick event for folders are attached to a non-interactive element (div).

Desired behavior:

It should be possible to interact with folders (collapsing/expanding) with a keyboard.

Steps to reproduce: (app code and test code)

See the gif below. Folders don't participate in keyboard navigation.

Mar-18-2019 21-43-16
@jennifer-shehane jennifer-shehane added pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX labels Mar 19, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Mar 19, 2019
@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label Mar 19, 2019
@desfero desfero mentioned this issue Apr 8, 2019
Merged
@jennifer-shehane jennifer-shehane added the type: accessibility ♿️ Improvements for accessibility label Apr 8, 2019
@nuagesdencre
Copy link

I'll take a look at it!

Closed
1 task
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Mar 13, 2021
@Manuel-Suarez-Abascal
Copy link
Contributor

Manuel-Suarez-Abascal commented Mar 13, 2021 •
edited
Loading

@jennifer-shehane @desfero I have tackled this issue. Can I get a review for this PR, please?

Merged
1 task
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 23, 2021

The code for this is done in cypress-io/cypress#15648, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2021

Released in 7.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: accessibility ♿️ Improvements for accessibility type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(issue-3741): added keyboard support for folder
feat: added keyboad support for folders
4 participants
@jennifer-shehane @desfero @nuagesdencre @Manuel-Suarez-Abascal