Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass list of detected browsers to plugins file via config object #5067

Closed
bahmutov opened this issue Aug 30, 2019 · 2 comments · Fixed by #5068
Closed

Pass list of detected browsers to plugins file via config object #5067

bahmutov opened this issue Aug 30, 2019 · 2 comments · Fixed by #5068
Assignees
@bahmutov

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Aug 30, 2019 •
edited
Loading

Currently in v3.4.1 we detect browsers on the user's system, then load the cypress/plugins/index.js file, but the config object we pass does NOT have the list of browsers. By passing the list of browsers via config we can let the user check if a required browser has been detected for example.

Second goal:
allow plugins to return the config object with modified browsers list and then use it.
@bahmutov bahmutov self-assigned this Aug 30, 2019
@bahmutov bahmutov mentioned this issue Aug 30, 2019
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Aug 30, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Sep 10, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 21, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Nov 12, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Nov 19, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 19, 2019

The code for this is done in cypress-io/cypress#5068, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

@snyk-bot snyk-bot mentioned this issue Dec 21, 2019
Open
@jennifer-shehane jennifer-shehane mentioned this issue Dec 23, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Mar 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass list of browsers to plugins file cypress-io/cypress
1 participant
@bahmutov