Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for write permissions during scaffolding #7310

Closed
flotwig opened this issue May 12, 2020 · 1 comment
Closed

Remove need for write permissions during scaffolding #7310

flotwig opened this issue May 12, 2020 · 1 comment
Labels
pkg/server This is due to an issue in the packages/server directory stage: ready for work The issue is reproducible and in scope type: error message

Comments

@flotwig
Copy link
Contributor

flotwig commented May 12, 2020

Current behavior:

Cypress's scaffolding will prevent tests from proceeding if it fails.

Desired behavior:

When Cypress's scaffolding fails, warn, set the config value that failed to false (ex. supportFile: false, pluginsFile: false and continue on.

This is especially important in run mode, where pluginsFile is the only file scaffolded, and failures to scaffold lead to test failure:

// TODO: we currently always scaffold the plugins file
// even when headlessly or else it will cause an error when
// we try to load it and it's not there. We must do this here
// else initialing the plugins will instantly fail.
if (cfg.pluginsFile) {
debug('scaffolding with plugins file %s', cfg.pluginsFile)
return scaffold.plugins(path.dirname(cfg.pluginsFile), cfg)
}

Related: #7126

@flotwig
Copy link
Contributor Author

flotwig commented Feb 24, 2023

Fixed, see related issues.

@flotwig flotwig closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/server This is due to an issue in the packages/server directory stage: ready for work The issue is reproducible and in scope type: error message
Projects
None yet
Development

No branches or pull requests

2 participants