From b0c6ef13dbe30e43402d4b10771cf8f16b0afc8c Mon Sep 17 00:00:00 2001 From: Lila Conlee Date: Tue, 23 Oct 2018 13:44:38 -0500 Subject: [PATCH 1/2] Only pull hook name out of double quotes if runnable type is 'hook' --- packages/driver/src/cypress/runner.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/driver/src/cypress/runner.coffee b/packages/driver/src/cypress/runner.coffee index f27c0cc0e0a1..15a96379d89c 100644 --- a/packages/driver/src/cypress/runner.coffee +++ b/packages/driver/src/cypress/runner.coffee @@ -807,7 +807,7 @@ create = (specWindow, mocha, Cypress, cy) -> test.wallClockStartedAt ?= wallClockStartedAt ## if this isnt a hook, then the name is 'test' - hookName = getHookName(runnable) or "test" + hookName = if runnable.type is "hook" then getHookName(runnable) else "test" ## if we haven't yet fired this event for this test ## that means that we need to reset the previous state From ab06aaeb0e43828f29f65365b300f5bfaf1266ab Mon Sep 17 00:00:00 2001 From: Lila Conlee Date: Wed, 24 Oct 2018 09:21:48 -0500 Subject: [PATCH 2/2] Add test --- .../test/cypress/integration/cypress/runner_spec.coffee | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/driver/test/cypress/integration/cypress/runner_spec.coffee b/packages/driver/test/cypress/integration/cypress/runner_spec.coffee index 096a34a99937..cd076987a76d 100644 --- a/packages/driver/test/cypress/integration/cypress/runner_spec.coffee +++ b/packages/driver/test/cypress/integration/cypress/runner_spec.coffee @@ -5,6 +5,12 @@ Cypress.on "test:after:run", (test) -> pending.push(test) describe "src/cypress/runner", -> + it 'handles "double quotes" in test name', (done) -> + cy.once "log:added", (log) -> + expect(log.hookName).to.equal("test") + done() + cy.wrap({}) + context "pending tests", -> it "is not pending", ->