Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end() throws exception if drone has already landed, or lost power, through mishap #126

Closed
ceperman opened this issue Nov 26, 2021 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ceperman
Copy link

end() attempts to land the drone normally and doesn't take into account that the flight may have ended badly e.g. crashed (i.e. already landed) or worse (crashed and battery popped out - this has happen to me on a number of occasions). In both of these situations, end() will hang retrying land() and eventually throw an exception. This function is typically called during normal application termination, but the exception means that the application may never close. Ditto the enclosed streamoff() command.

end() would be more robust if it did not expect a response from its communication with the drone or used a much reduced timeout, and did not raise an exception if it failed.

@M4GNV5 M4GNV5 added bug Something isn't working enhancement New feature or request labels Nov 28, 2021
@M4GNV5 M4GNV5 closed this as completed in 5c5848f Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants