Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor socket keepalive settings #84

Closed
danielealbano opened this issue Dec 31, 2021 · 0 comments · Fixed by #180
Closed

Honor socket keepalive settings #84

danielealbano opened this issue Dec 31, 2021 · 0 comments · Fixed by #180
Assignees
@danielealbano
Labels
enhancement New feature or request
Milestone
v0.2

Comments

@danielealbano
Copy link
Owner

The current networking implementation in cachegrand already has a basic support for handling the socket keepalive settings, but this needs to be improved as it's not possible to set the time, the interval and the probes parameters instead already exposed in the config file.

These settings are extremely useful, especially when cachegrand runs behind reverse nats (common on cloud providers, e.g. Amazon) as otherwise long running connections would be closed resulting in failed operations.
@danielealbano danielealbano added the enhancement New feature or request label Dec 31, 2021
@danielealbano danielealbano added this to the v0.2 milestone Dec 31, 2021
@danielealbano danielealbano self-assigned this Aug 17, 2022
@danielealbano danielealbano mentioned this issue Aug 17, 2022
Merged
@danielealbano danielealbano linked a pull request Aug 17, 2022 that will close this issue
Honor socket keepalive settings #180
Merged
danielealbano added a commit that referenced this issue Aug 17, 2022
@danielealbano
Honor socket keepalive settings (#180)
224b39e 
This PR implements 3 new network io functions to set the keepalive idel, interval and count and update the mechanism used to enable / disable the keepalive to:

set the keepalive parameters only if the keepalive block is present in the configuration
do not fail, only report a warning, if the keepalive parameters are for some reason refused

The PR closes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielealbano danielealbano

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2
Development

Successfully merging a pull request may close this issue.

Honor socket keepalive settings danielealbano/cachegrand
1 participant
@danielealbano