Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ChartsOrg/Charts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.2
Choose a base ref
...
head repository: ChartsOrg/Charts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.3
Choose a head ref
  • 17 commits
  • 29 files changed
  • 5 contributors

Commits on Jul 27, 2015

  1. CONTRIBUTING.md 

    You will now see this when creating new issues. Ha ha!
    @danielgindi
    danielgindi committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    3e51af3 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2015

  1. merge from upstream master (+3 squashed commits) 

    Squashed commits:
[c861fea] add fix for horizontal bar chart
[2f75778] apply the same logic for getMarkerPosition
[baca6dd] try to fix wrong position bug. use entry.xIndex instead of j of dataSet.entryCount to calculate the offset and position
    @liuxuan30
    liuxuan30 committed Jul 28, 2015
    Configuration menu
    Copy the full SHA
    9686ac7 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2015

  1. Catch up with a small feature from 2.1.1 (Fixes #249)

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    2a0e534 View commit details
    Browse the repository at this point in the history

  2. isStacked getter for BarChartDataEntry

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    54da4c2 View commit details
    Browse the repository at this point in the history

  3. This should be an optional

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    1cc1c7d View commit details
    Browse the repository at this point in the history

  4. Clear min/max when there's no data

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    233e03d View commit details
    Browse the repository at this point in the history

  5. subRenderers accessor for Combined chart

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    799eadc View commit details
    Browse the repository at this point in the history

  6. Removed unnecessary condition

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    4c691cc View commit details
    Browse the repository at this point in the history

  7. Added outofbounds check in getEntryForHighlight (Fixes PhilJay/MPAndr… 

    …oidChart/issues/898)
    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    a59184f View commit details
    Browse the repository at this point in the history

  8. Added missing imports (Fixes #250)

    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    ab9f230 View commit details
    Browse the repository at this point in the history

  9. updated podspec

    @pmairoldi
    pmairoldi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    2e12966 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #254 from petester42/master 

    Updated podspec so version does not have to be specified twice
    @danielgindi
    danielgindi committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    7aec807 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2015

  1. Merge pull request #248 from liuxuan30/BarChart+HorizontalBarFix 

    Fixes bar charts x-index calculations (Fixes #214 and fixes #242)

Specifically when yValues are missing
    @danielgindi
    danielgindi committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    2177f7d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2015

  1. Add a Code Hunt vote badge to README.md 

    @danielgindi FYI, your repo has been featured today on @CodeHuntIO   

http://codehunt.io/sub/ios-charts/

**TL;DR** Code Hunt helps programmers discover and discuss awesome code.  

This pull-request adds a "vote" badge to your README.md:   

[![CodeHunt.io](https://img.shields.io/badge/vote-codehunt.io-02AFD1.svg)](http://codehunt.io/sub/ios-charts/?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)   

Fingers crossed that we can drive more attention to your brilliant work.   

Happy coding!
@chrisjacob ^_^   

p.s. I hope you found this PR helpful, if not please [let me know](mailto:chris@codehunt.io).   

p.p.s I've also tweeted about your project https://twitter.com/hunt_swift/status/627841135570984960
    @CodeHuntIO
    CodeHuntIO committed Aug 2, 2015
    Configuration menu
    Copy the full SHA
    f4f3563 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2015

  1. Merge pull request #262 from CodeHuntIO/patch-1 

    Add a Code Hunt vote badge to README.md
    @danielgindi
    danielgindi committed Aug 5, 2015
    Configuration menu
    Copy the full SHA
    f858a0d View commit details
    Browse the repository at this point in the history

  2. Minor cleanup

    @danielgindi
    danielgindi committed Aug 5, 2015
    Configuration menu
    Copy the full SHA
    8cfefdb View commit details
    Browse the repository at this point in the history

  3. Bumped to 2.1.3

    @danielgindi
    danielgindi committed Aug 5, 2015
    Configuration menu
    Copy the full SHA
    4d5c4f6 View commit details
    Browse the repository at this point in the history
Loading