Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow control of circle line width in Line Chart. #669

Closed
terloon opened this issue Jan 12, 2016 · 1 comment
Closed

Allow control of circle line width in Line Chart. #669

terloon opened this issue Jan 12, 2016 · 1 comment

Comments

@terloon
Copy link

terloon commented Jan 12, 2016

I didn't see any way to modify the width of the circles in the line chart. This is my initial attempt at it. The current method performs a calculation halving the circle diameter. Right now I hard coded it to be the same value for the default radius, but it will look different for current implementations if they use this.

Needs invalid value checks and maybe a calculation to match previous look of halving diameter.

I have a commit for this, but I've never really shared to a github project before so learning how to do that now.

@liuxuan30
Copy link
Member

You can fork this repo, and create a new branch and you commit on this branch; when finished, push this branch to your forked repo, and create a Pull Request(PR) to this repo's master branch.
You can learn it from github, there are guidance like: https://help.github.com/articles/using-pull-requests/
Practice makes perfect :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants