-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite loop when setting data on ChartDataEntry object #86
Comments
Actually it isn't, the correct fix would be to changed line 54 to be === instead of == Thanks for the catch :-) |
Hi, thanks for the quick reply. I changed that line as you suggested but it's now causing EXC_BAD_ACCESS on the line that I thought may be the problem: Making this change does appear to fix it: if (object!.data !== data) I'm new to Swift so I'm just not sure of the full implications of this. Is !object!.isEqual(self) not somehow causing an infinite isEqual() loop on itself? |
It was just another thing I missed. It should have been isEqual(data)... A commit coming right up. |
Thanks! |
I'm setting additional data on the ChartEntryObject to pass it to the Marker view:
This causes EXC_BAD_ACCESS infinite loop in ChartDataEntry.swift:
The problem is fixed by changing line 64 of ChartDataEntry.swift from:
to
Is it safe to do so?
The text was updated successfully, but these errors were encountered: