Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client is creating many websocket connections #1

Open
Computron010 opened this issue Mar 20, 2024 · 3 comments
Open

Client is creating many websocket connections #1

Computron010 opened this issue Mar 20, 2024 · 3 comments

Comments

@Computron010
Copy link

Computron010 commented Mar 20, 2024 •
edited
Loading

Hello, first thanks for creating this.

I am experiencing an issue where, even without any proxies (not passing an agent into the WebScocket configuration), the client is creating many WebSockets connections, without closing any of them. This is causing an excessive number of PINGs being sent from the client.

Example log output 
WebSocket connection opened
{"id":"4f4fba69-665a-4b7a-a0fe-f90f98a3209c","version":"1.0.0","action":"PING","data":{}}
{
  id: 'b6fb6b61-0126-4503-b9f2-f9fda474758a',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'b6fb6b61-0126-4503-b9f2-f9fda474758a', origin_action: 'PONG' }
WebSocket connection opened
{"id":"fbf861de-c8ee-4726-be6f-931f22239f9d","version":"1.0.0","action":"PING","data":{}}
{
  id: '47018fc0-af52-4c18-9efd-a69abb06c0e8',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '47018fc0-af52-4c18-9efd-a69abb06c0e8', origin_action: 'PONG' }
WebSocket connection opened
{"id":"88d396b0-b0b8-44a7-bfdb-0f808e3a16b0","version":"1.0.0","action":"PING","data":{}}
{
  id: '8f2bec8c-ee38-4085-9bf4-d497a4a5dbf7',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '8f2bec8c-ee38-4085-9bf4-d497a4a5dbf7', origin_action: 'PONG' }
WebSocket connection opened
{"id":"1b4b8f9e-4672-4947-99ea-52edc71419e2","version":"1.0.0","action":"PING","data":{}}
{
  id: '8ba673fb-da32-4006-927c-9ae3df3e757f',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '8ba673fb-da32-4006-927c-9ae3df3e757f', origin_action: 'PONG' }
WebSocket connection opened
WebSocket connection opened
WebSocket connection opened
{"id":"4db8b5ee-8441-4291-b4db-459d2f96ed24","version":"1.0.0","action":"PING","data":{}}
{
  id: '9defbe8f-0dac-4a4f-b83a-6ae8e16208a4',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '9defbe8f-0dac-4a4f-b83a-6ae8e16208a4', origin_action: 'PONG' }
{"id":"391a9b42-8e15-4fa1-b0b0-4509bef9b769","version":"1.0.0","action":"PING","data":{}}
{
  id: 'ff0d0e81-ea69-48fb-9bfa-c3af2676b18b',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'ff0d0e81-ea69-48fb-9bfa-c3af2676b18b', origin_action: 'PONG' }
{"id":"dfda18d8-ace4-4c5e-90ef-6f3930086f3d","version":"1.0.0","action":"PING","data":{}}
{
  id: '47a764a6-1361-41d3-a102-f98cdfa6fb25',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '47a764a6-1361-41d3-a102-f98cdfa6fb25', origin_action: 'PONG' }
WebSocket connection opened
{"id":"c7f07a39-a7c1-44b1-a20b-3aa3f8663fc1","version":"1.0.0","action":"PING","data":{}}
{
  id: '1e41965a-4a85-4c06-804c-e0bf7dffc707',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '1e41965a-4a85-4c06-804c-e0bf7dffc707', origin_action: 'PONG' }
WebSocket connection opened
WebSocket connection opened
WebSocket connection opened
{"id":"bff11f95-82a8-447d-ad56-a8e1e1fee7e5","version":"1.0.0","action":"PING","data":{}}
{"id":"cc4cd736-f948-4195-acba-b78c1916218a","version":"1.0.0","action":"PING","data":{}}
{
  id: '68a6bcc2-e7b1-470c-9a00-bf7314693276',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '68a6bcc2-e7b1-470c-9a00-bf7314693276', origin_action: 'PONG' }
WebSocket connection opened
{
  id: '102ebbd3-f771-49b9-9ea4-ecb1448d0daa',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '102ebbd3-f771-49b9-9ea4-ecb1448d0daa', origin_action: 'PONG' }
{"id":"bef44604-d67d-4982-9c55-22789e8c3405","version":"1.0.0","action":"PING","data":{}}
{
  id: '508e0af7-890b-401a-bb40-b23e0e082ab1',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '508e0af7-890b-401a-bb40-b23e0e082ab1', origin_action: 'PONG' }
WebSocket connection opened
{"id":"60815b7f-5fa1-49f1-bad0-37e25727a06e","version":"1.0.0","action":"PING","data":{}}
{
  id: '5b43a412-ecf2-45bb-aeec-d99682501b5d',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '5b43a412-ecf2-45bb-aeec-d99682501b5d', origin_action: 'PONG' }
{"id":"ff84c311-2289-427a-ad65-a565f478b9ac","version":"1.0.0","action":"PING","data":{}}
{
  id: 'ef843930-ea26-44c8-8973-4643f229f0af',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'ef843930-ea26-44c8-8973-4643f229f0af', origin_action: 'PONG' }
WebSocket connection opened
{"id":"3cd6c933-e2ba-4a32-8024-9e964b6a8cc2","version":"1.0.0","action":"PING","data":{}}
{
  id: '99b096ef-4b74-40d1-82aa-cd84dbc0f36c',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '99b096ef-4b74-40d1-82aa-cd84dbc0f36c', origin_action: 'PONG' }
WebSocket connection opened
{"id":"76a3398a-3684-450e-9687-5cc399793d11","version":"1.0.0","action":"PING","data":{}}
{
  id: 'faaa8c9c-4a3f-4b79-906d-1d77b07c23fd',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'faaa8c9c-4a3f-4b79-906d-1d77b07c23fd', origin_action: 'PONG' }
WebSocket connection opened
{"id":"cb98f669-4d06-4890-a67d-ed1b95b251e0","version":"1.0.0","action":"PING","data":{}}
WebSocket connection opened
{
  id: 'a4e91226-ce23-4909-bff3-a2ceab21f6de',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'a4e91226-ce23-4909-bff3-a2ceab21f6de', origin_action: 'PONG' }
WebSocket connection opened
WebSocket connection opened
{"id":"d9eaa557-2942-487a-b1d9-b11d90100eff","version":"1.0.0","action":"PING","data":{}}
WebSocket connection opened
{
  id: 'bb7f644e-94b7-4218-8f3a-7b2d7e0604a4',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'bb7f644e-94b7-4218-8f3a-7b2d7e0604a4', origin_action: 'PONG' }
{"id":"d71dd32e-ad09-4e9a-840d-c221ff9212ba","version":"1.0.0","action":"PING","data":{}}
WebSocket connection opened
{
  id: '3f455b14-08c7-4aa0-8e47-881004786e0a',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '3f455b14-08c7-4aa0-8e47-881004786e0a', origin_action: 'PONG' }
{"id":"bf90df84-1d13-47cf-a9ce-f07e8e8de883","version":"1.0.0","action":"PING","data":{}}
{
  id: '3ccc6a53-54e7-44f1-b62b-20d4c4be9f74',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '3ccc6a53-54e7-44f1-b62b-20d4c4be9f74', origin_action: 'PONG' }
{"id":"73fa6068-4f21-481f-896b-7d839e265078","version":"1.0.0","action":"PING","data":{}}
{
  id: '011e3097-6e8e-479a-bbb7-e2be42583a20',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '011e3097-6e8e-479a-bbb7-e2be42583a20', origin_action: 'PONG' }
WebSocket connection opened
{"id":"ebf1764f-4aed-491d-b147-2dd91fb550bd","version":"1.0.0","action":"PING","data":{}}
{
  id: '417338a6-d595-4893-a1b2-b7f088038785',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '417338a6-d595-4893-a1b2-b7f088038785', origin_action: 'PONG' }
WebSocket connection opened
{"id":"6717d34a-6eec-4278-a2b2-27476d494e54","version":"1.0.0","action":"PING","data":{}}
{
  id: '5403417b-ddc1-49c2-9651-aaca13adb9b0',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '5403417b-ddc1-49c2-9651-aaca13adb9b0', origin_action: 'PONG' }
{"id":"e5794b4e-3994-4f7c-a6ec-d008f1a05268","version":"1.0.0","action":"PING","data":{}}
{
  id: '33addab5-3119-47e9-9b06-0e995838120c',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '33addab5-3119-47e9-9b06-0e995838120c', origin_action: 'PONG' }
WebSocket connection opened
{"id":"339cd303-de38-43ff-a9a6-de0f98f350fb","version":"1.0.0","action":"PING","data":{}}
{
  id: '5c39828b-9131-41a3-b7cf-502d059058fa',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '5c39828b-9131-41a3-b7cf-502d059058fa', origin_action: 'PONG' }
{"id":"bd382135-bcce-4857-921a-8211a596c530","version":"1.0.0","action":"PING","data":{}}
{
  id: '3ef931a4-fd86-4110-a27b-2ac8fb0e233f',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '3ef931a4-fd86-4110-a27b-2ac8fb0e233f', origin_action: 'PONG' }
{"id":"e0529840-c61b-4efa-91b7-0cfedf61b942","version":"1.0.0","action":"PING","data":{}}
{
  id: 'e2f0002b-762d-4f7d-ba33-ab13f5c8a2a1',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'e2f0002b-762d-4f7d-ba33-ab13f5c8a2a1', origin_action: 'PONG' }
WebSocket connection opened
{"id":"72632306-18a2-4c00-9342-b41d1b5a95e4","version":"1.0.0","action":"PING","data":{}}
{
  id: 'f78593cc-c48a-4ac5-9f68-d9514d80057a',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'f78593cc-c48a-4ac5-9f68-d9514d80057a', origin_action: 'PONG' }
WebSocket connection opened
{"id":"886e6782-eae1-4640-83c9-fca431d6400e","version":"1.0.0","action":"PING","data":{}}
{
  id: '6553371d-db57-485c-a7d1-0a14aff1c5a2',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '6553371d-db57-485c-a7d1-0a14aff1c5a2', origin_action: 'PONG' }
WebSocket connection opened
{"id":"4b4ddbce-f8b1-425d-9800-0a1cac9063c0","version":"1.0.0","action":"PING","data":{}}
{"id":"1449c8e6-b320-4046-a02c-d159fce5f7b6","version":"1.0.0","action":"PING","data":{}}
{
  id: '5ee3246f-3dd8-4e1c-953e-90d2f79ac2f3',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '5ee3246f-3dd8-4e1c-953e-90d2f79ac2f3', origin_action: 'PONG' }
{
  id: '56b0659a-5215-49cd-ba27-41acb048d4bc',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '56b0659a-5215-49cd-ba27-41acb048d4bc', origin_action: 'PONG' }
{"id":"b22d73b1-0176-4880-825a-f7f5dca376f6","version":"1.0.0","action":"PING","data":{}}
{
  id: 'ae432db4-a235-4cb6-91d2-42d7e54820bb',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: 'ae432db4-a235-4cb6-91d2-42d7e54820bb', origin_action: 'PONG' }
WebSocket connection opened
WebSocket connection opened
{"id":"240e52dd-562a-403b-a8b6-b77505c7e127","version":"1.0.0","action":"PING","data":{}}
{
  id: '7b6b71eb-0047-4bd9-b92f-fafad05d1840',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '7b6b71eb-0047-4bd9-b92f-fafad05d1840', origin_action: 'PONG' }
WebSocket connection opened
{"id":"0c8bcf13-f1f0-44fc-9b89-3f3e2e5f3258","version":"1.0.0","action":"PING","data":{}}
{
  id: '59a46046-9a16-4f71-b3b2-96761b823240',
  version: '1.0.0',
  action: 'PONG',
  data: {}
}
{ id: '59a46046-9a16-4f71-b3b2-96761b823240', origin_action: 'PONG' }

My node version is v20.11.1

Thanks!
@dvdieu
Copy link

dvdieu commented Mar 22, 2024

i got the same issue

@dante4rt
Copy link
Owner

Hello, first thanks for creating this.

I am experiencing an issue where, even without any proxies (not passing an agent into the WebScocket configuration), the client is creating many WebSockets connections, without closing any of them. This is causing an excessive number of PINGs being sent from the client.

Example log output
My node version is v20.11.1

Thanks!

Hey there,
Thanks for reaching out and bringing this to my attention.

I see there's an issue with the WebSocket setup causing multiple connections without closure, leading to an influx of PINGs from the client. I'll dive into the code and work on fixing this as soon as I can. Your patience is much appreciated!

Thanks again for flagging this.

@GonkSolana
Copy link

Can we know where did you get your proxies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dvdieu @dante4rt @Computron010 @GonkSolana