From a212e999035d2c3d8b0bfe223ebb298d8179dadf Mon Sep 17 00:00:00 2001
From: Sam Rawlins <srawlins@google.com>
Date: Thu, 12 Oct 2023 07:34:44 -0700
Subject: [PATCH] Remove cross-export warning.

---
 lib/src/model/model_element.dart | 13 -------------
 lib/src/model/package_graph.dart |  1 -
 lib/src/warnings.dart            |  7 -------
 3 files changed, 21 deletions(-)

diff --git a/lib/src/model/model_element.dart b/lib/src/model/model_element.dart
index 7e9ea98ab4..064eccf009 100644
--- a/lib/src/model/model_element.dart
+++ b/lib/src/model/model_element.dart
@@ -538,19 +538,6 @@ abstract class ModelElement extends Canonicalization
       };
     }).toList(growable: true);
 
-    // Avoid claiming canonicalization for elements outside of this element's
-    // defining package.
-    // TODO(jcollins-g): Make the else block unconditional.
-    if (candidateLibraries.isNotEmpty &&
-        !candidateLibraries.any((l) => l.package == definingLibrary.package)) {
-      warn(PackageWarning.reexportedPrivateApiAcrossPackages,
-          message: definingLibrary.package.fullyQualifiedName,
-          referredFrom: candidateLibraries);
-    } else {
-      candidateLibraries
-          .removeWhere((l) => l.package != definingLibrary.package);
-    }
-
     if (candidateLibraries.isEmpty) {
       return null;
     }
diff --git a/lib/src/model/package_graph.dart b/lib/src/model/package_graph.dart
index 73a9f7efd4..46c42c7d16 100644
--- a/lib/src/model/package_graph.dart
+++ b/lib/src/model/package_graph.dart
@@ -418,7 +418,6 @@ class PackageGraph with CommentReferable, Nameable, ModelBuilder {
       PackageWarning.ambiguousDocReference ||
       PackageWarning.ignoredCanonicalFor ||
       PackageWarning.packageOrderGivesMissingPackageName ||
-      PackageWarning.reexportedPrivateApiAcrossPackages ||
       PackageWarning.unresolvedDocReference ||
       PackageWarning.unknownMacro ||
       PackageWarning.unknownHtmlFragment ||
diff --git a/lib/src/warnings.dart b/lib/src/warnings.dart
index 29d749eea9..095af3ea48 100644
--- a/lib/src/warnings.dart
+++ b/lib/src/warnings.dart
@@ -181,13 +181,6 @@ enum PackageWarning implements Comparable<PackageWarning> {
         'The category-order flag on the command line was given the name of a '
         'nonexistent package',
   ),
-  reexportedPrivateApiAcrossPackages(
-    'reexported-private-api-across-packages',
-    'private API of {0} is reexported by libraries in other packages: ',
-    shortHelp:
-        'One or more libraries reexports private API members from outside its '
-        'own package',
-  ),
   unresolvedDocReference(
     'unresolved-doc-reference',
     'unresolved doc reference [{0}]',