This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
feat!: handle new drive error codes #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
suggested changes
Sep 6, 2021
lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js
Show resolved
Hide resolved
test/unit/grpcServer/handlers/createGrpcErrorFromDriveResponse.js
Outdated
Show resolved
Hide resolved
shumkov
suggested changes
Sep 8, 2021
lib/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js
Outdated
Show resolved
Hide resolved
added 2 commits
September 8, 2021 13:32
shumkov
reviewed
Sep 8, 2021
shumkov
reviewed
Sep 8, 2021
shumkov
reviewed
Sep 8, 2021
added 2 commits
September 8, 2021 14:05
shumkov
reviewed
Sep 8, 2021
shumkov
reviewed
Sep 8, 2021
test/unit/grpcServer/handlers/platform/broadcastStateTransitionHandlerFactory.js
Outdated
Show resolved
Hide resolved
added 8 commits
September 8, 2021 15:45
shumkov
changed the title
shumkov
approved these changes
Sep 15, 2021
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Handle new Drive error codes dashevo/js-drive#562
What was done?
infofield of ABCI response, instead oflogHow Has This Been Tested?
Breaking Changes
DAPI responds with new error codes
Checklist:
For repository code-owners and collaborators only