From 4c3ed8e38be26375d11c8edc748ee41a21588c88 Mon Sep 17 00:00:00 2001 From: Jesse Whitehouse Date: Wed, 12 Jul 2023 16:35:11 -0500 Subject: [PATCH] Update test suite and example script to remove superfluous settings Signed-off-by: Jesse Whitehouse --- examples/sqlalchemy.py | 2 +- tests/e2e/sqlalchemy/test_basic.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/sqlalchemy.py b/examples/sqlalchemy.py index 35160658..efb8f0bf 100644 --- a/examples/sqlalchemy.py +++ b/examples/sqlalchemy.py @@ -89,7 +89,7 @@ class SampleObject(base): name = Column(String(255), primary_key=True) episodes = Column(Integer) - some_bool = Column(BOOLEAN(create_constraint=False)) + some_bool = Column(BOOLEAN) base.metadata.create_all() diff --git a/tests/e2e/sqlalchemy/test_basic.py b/tests/e2e/sqlalchemy/test_basic.py index 1d3125f2..f17828eb 100644 --- a/tests/e2e/sqlalchemy/test_basic.py +++ b/tests/e2e/sqlalchemy/test_basic.py @@ -148,7 +148,7 @@ def test_create_table_not_null(db_engine, metadata_obj: MetaData): metadata_obj, Column("name", String(255)), Column("episodes", Integer), - Column("some_bool", BOOLEAN(create_constraint=False), nullable=False), + Column("some_bool", BOOLEAN, nullable=False), ) metadata_obj.create_all() @@ -201,7 +201,7 @@ def test_create_insert_drop_table_core(base, db_engine, metadata_obj: MetaData): metadata_obj, Column("name", String(255)), Column("episodes", Integer), - Column("some_bool", BOOLEAN(create_constraint=False)), + Column("some_bool", BOOLEAN), Column("dollars", DECIMAL(10, 2)), ) @@ -240,7 +240,7 @@ class SampleObject(base): name = Column(String(255), primary_key=True) episodes = Column(Integer) - some_bool = Column(BOOLEAN(create_constraint=False)) + some_bool = Column(BOOLEAN) base.metadata.create_all() @@ -272,7 +272,7 @@ def test_dialect_type_mappings(base, db_engine, metadata_obj: MetaData): metadata_obj, Column("string_example", String(255)), Column("integer_example", Integer), - Column("boolean_example", BOOLEAN(create_constraint=False)), + Column("boolean_example", BOOLEAN), Column("decimal_example", DECIMAL(10, 2)), Column("date_example", Date), )