From cb8f583b099efd420a654e116a4f3f42a999c259 Mon Sep 17 00:00:00 2001 From: Oliver Sanders Date: Thu, 6 Oct 2022 10:15:33 +0100 Subject: [PATCH] 8.0.x.patch (#5178) * fix reversed data-store edge source-target (#5156) Co-authored-by: David Sutherland * `log_vc_info`: Redirect diff straight to file to avoid blocking pipe (#5139) * log_vc_info: redirect diff straight to file to avoid blocking pipe * Update changelog * A no-flow task should not merge and retrigger incomplete children (#5146) Prevent no-flow merge. * remote-install: add "ana/" to the default install list (#5137) * The `ana/` directory is used by `rose_ana` to load comparison modules. * These are typically run where the data is generated which is often remote. * These directories typically contain a small number of Python files. * Auto bump dev version on release * Run GH Actions tests on push to `8.*.x` branches * Db store force triggered (#5023) Store force-triggered flag in the run DB. * Add a new functional test. * Remove some redundant DB updates. * Update change log. * remote: ensure all remote commands use a platform config (#5152) Remote interfaces (SSH & rsync) now all require a platform object for configuration purposes (e.g. "ssh command"). Convenience interfaces added for remote calls to Cylc servers which use the localhost platform configuration. These are now used for: * `cylc play` command re-invocation on a Cylc server. * Evaluation of host selection rankings (via `cylc psutil`). * The detect old contact file check, which tests whether a workflow is still running on the server recored in the contact file. * host select: allow unary operators in ranking expressions (#5151) * host select: allow unary operators in ranking expressions * Whitelist unary operators (required for expressions like `-1 * x`) in `[scheduler][run hosts]ranking` expressions. * Improve error formatting. * Update tests/unit/test_exceptions.py Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> * reinstall changes to `rose-suite.conf` (#5125) reinstall: ensure rose-suite.conf changes trigger reinstallation Co-authored-by: David Sutherland Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com> Co-authored-by: Hilary James Oliver Co-authored-by: Tim Pillinger <26465611+wxtim@users.noreply.github.com> --- cylc/flow/host_select.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cylc/flow/host_select.py b/cylc/flow/host_select.py index 40b8c006b72..3658cc7fa76 100644 --- a/cylc/flow/host_select.py +++ b/cylc/flow/host_select.py @@ -563,7 +563,7 @@ def _get_metrics(hosts, metrics, data=None): if proc.poll() is None: continue del proc_map[host] - out, err = proc.communicate() + out, err = (stream.strip() for stream in proc.communicate()) if proc.wait(): # Command failed LOG.warning(