Sticky header is disappearing when scrolling

[jrcacd]

When scroll and the header reaches the top, it disappears

adapter.layoutManager = StaggeredGridLayoutManager(...)
adapter.setDisplayHeadersAtStartUp(true)
adapter.setStickyHeaders(true)

[davideas]

@jrcacd, please more information.

[jrcacd]

After #521 has fixed the above started.

[mattlaabs]

I might experience the same bug, can't tell exactly when it started.
Scenario is: sticky headers and under the current header there are more items than fit on the screen.
When scrolling down, the next header does not show up in place but replaces the current header at the sticky position while leaving an empty space at its correct position. Once the new header is scrolled to the top, everything looks ok. Scrolling up works fine.
A temporary workaround for me is to set a 0-sized recycler pool for the header view. (Probably has performance impact, but not relevant for my scenario.)

[jrcacd]

The same bug

[davideas]

If you use 5.0.1, do you still have the issue?
I think it is related to #568. I have verified the bug described by @mattlaabs, but I have to manually call onViewRecycled() with the old sticky header.

[mattlaabs]

With 5.0.1 the issue is not reproducible for me.
I never call onViewRecycled() manually.

[davideas]

@mattlaabs, I, have to recycle manually. So you confirm that is related to the change I made in 5.0.2.

I have put back the old code in the StickyHeaderHelper where I set the view not recyclable, the issue doesn't appear anymore, this means the view must not be recycled, and I will recycle manually when not visible anymore.

[mattlaabs]

Yes, just switched back to 5.0.2 (with the 0-sized pool workaround removed) and the error is back.