tests failing on IE/Edge

[gordonwoodhull]

Microsoft uses subtly different syntax for a lot of style values, also within the CSS/HTML spec but a different interpretation.

It looks like we have two tests failing on all IE/Edge because of this:

dc.compositeChart

    rendering the chart
        the chart clip paths
        should have clip path refs

dc.coordinateGridChart

    rendering
        clip paths
        should add clip path refs to the chart body

https://saucelabs.com/beta/tests/d992de1575c24c07b289df4b65ddf55f/jsunit

@kum-deepak, do you have access to these browsers? We used to be compatible back to IE9 (!!) and if d3.js still is, we should still be too. But I think testing on IE11 and latest Edge is sufficient.

It's strange that we only do saucelabs cross-platform tests when pushing to a branch, not for PRs. It takes quite a bit longer (3min vs 1min), perhaps that was the reasoning. What do you think about changing that?

If you want to see these failures, go to the Travis build history

https://travis-ci.org/dc-js/dc.js/builds

and click a failing build, go to the end of the log and it will give you links to the failing builds at saucelabs.

[kum-deepak]

I am on Mac, will figure some way to test on IE browsers.

[gordonwoodhull]

The official IE VMs are quite good: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

[kum-deepak]

The issue might actually be simpler. Both these test cases use a custom matcher toMatchUrl, which I had cleaned up. Looks like IE did not like it :).

Thanks for the links to the VMs - will use those.

[gordonwoodhull]

That's great. Yes, you'll find that a lot of the matchers do funny things for M$.

Thanks for all your hard work!

[gordonwoodhull]

fixed by #1378