Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit with code 1 when an issue is found #46

Closed
benesjan opened this issue Mar 6, 2024 · 5 comments
Closed

Exit with code 1 when an issue is found #46

benesjan opened this issue Mar 6, 2024 · 5 comments
Assignees
@gas1cent
Milestone
v1.1.5

Comments

@benesjan
Copy link

benesjan commented Mar 6, 2024 •
edited
Loading

Currently the command does not fail with exit code 1 when an issue is found. This makes it impractical to use in CI.
@gas1cent gas1cent self-assigned this Mar 6, 2024
@gas1cent gas1cent added this to the v1.2.0 milestone Mar 6, 2024
@gas1cent
Copy link
Member

gas1cent commented Mar 6, 2024

Agree, it makes total sense. Thanks for the feedback!

@srdtrk
Copy link

srdtrk commented Aug 12, 2024

Any updates on this issue? I can open a PR there is no progress.

@gas1cent
Copy link
Member

@srdtrk I will make a PR next week

@gas1cent gas1cent modified the milestones: v1.2.0, v1.1.5 Aug 19, 2024
@gas1cent
Copy link
Member

@srdtrk @benesjan please try v1.1.5

@srdtrk
Copy link

srdtrk commented Aug 22, 2024

Works for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gas1cent gas1cent

Labels
None yet
Projects
None yet
Milestone
v1.1.5
Development

No branches or pull requests
3 participants
@benesjan @srdtrk @gas1cent