Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database engine #229

Closed
Paulo--M-- opened this issue Sep 21, 2020 · 3 comments
Closed

Database engine #229

Paulo--M-- opened this issue Sep 21, 2020 · 3 comments

Comments

@Paulo--M--
Copy link

I am taking the liberty of including a small suggestion that I believe would improve this great package :-)

Your MySQL table creation scripts use 'MyISAM' as the DB engine. For my own purposes, I have changed this to 'InnoDB' so that transactions play nice... :-) Unless there is a specific reason why you are using MyISAM, I would suggest changing that to InnoDB in the scripts that you distribute -- just a thought...

And, again: great work -- thank you.

@ocram
Copy link
Contributor

ocram commented Sep 22, 2020

Thanks!

This is already tracked in #137 and #86.

If you’re using InnoDB instead of MyISAM in practice, we’re really happy to hear any feedback about your experience and possible adjustments you had to make.

As for changing the default engine, we may consider that in the future. And feedback from testing it priorly helps a lot with that, of course.

@ocram ocram closed this as completed Sep 22, 2020
@Paulo--M--
Copy link
Author

I changed all PHPAuth tables to InnoDB; in fact, I hardly ever use MyISAM anymore -- it all started because of transactions, years back, and the usefulness of commit/rollback. From a practical point of view, in some cases I need to act on PHPAuth tables AND some of my own tables -- having the rollback option is such a plus that everything is InnoDB. As far as I'm aware, this has always worked perfectly (having InnoDB PHPAuth tables, that is) but if there are any pitfalls I should be aware of, please feel free to point them out :-) Just to make things clear, I did not touch/adjust anything else: just changed the table engine to InnoDB -- is there something that is completely escaping my attention? :-) PHPAuth seems to be working perfectly...
Thanks again for this great piece of code.

@ocram
Copy link
Contributor

ocram commented Sep 30, 2020

Thanks! So #137 suggests you would really have to adjust the length of two email columns. Other than that, I don’t see any problems at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants