Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing recommended rules #556

Open
mvolkmann opened this issue Dec 4, 2020 · 4 comments
Open

missing recommended rules #556

mvolkmann opened this issue Dec 4, 2020 · 4 comments
Labels
design limitation Currently this is a limitation of the design requires type checking Implementation of this rule requires access to type checking information from TSC

Comments

@mvolkmann
Copy link

The description says "Supports recommended set of rules from ESLint and @typescript-eslint out of the box with no config."
It seems it does implement all the eslint:recommended rules, but only some of the plugin:@typescript-eslint/recommended rules.
For example, I think the following rules are missing:

await-thenable, explicit-module-boundary-types, no-floating-promises, no-for-in-array, no-non-null-asserted-optional-chain, no-non-null-assertion, no-unnecessary-type-assertion, no-unsafe-assignment, no-unsafe-call, no-unsafe-member-access, no-unsafe-return, no-var-requires, prefer-regexp-exec, restrict-plus-operands, restrict-template-expressions, triple-slash-reference, unbound-method, no-empty-function, no-implied-eval, and no-unused-vars.

Maybe the description should be changed to say that it implements "many" of the typescript-eslint/recommended rules.

@bartlomieju
Copy link
Member

@mvolkmann could you link to relevant configuration in typescript-eslint that lists these rules as recommended? Last time I checked I did not see most of them in recommended set.

@mvolkmann
Copy link
Author

@bartlomieju
Copy link
Member

@mvolkmann it seems the rules you've enumerated require type checking to enforce, which deno_lint can't do at the moment: #303, #270

@bartlomieju bartlomieju added design limitation Currently this is a limitation of the design requires type checking Implementation of this rule requires access to type checking information from TSC labels Aug 24, 2021
@Anutrix
Copy link

Anutrix commented Sep 1, 2023

The linked npmjs seems to not available anymore.
Here's a new link: https://typescript-eslint.io/rules/?supported-rules=recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design limitation Currently this is a limitation of the design requires type checking Implementation of this rule requires access to type checking information from TSC
Projects
None yet
Development

No branches or pull requests

3 participants