Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use linter for Browser code. Have selector for Deno/Browser? #780

Open
David-Else opened this issue Sep 7, 2020 · 3 comments
Open

Use linter for Browser code. Have selector for Deno/Browser? #780

David-Else opened this issue Sep 7, 2020 · 3 comments

Comments

@David-Else
Copy link

I would like to use the linter for all my Browser-based TypeScript and replace ESLint, but I need to use "deno.enable": true, to turn the linter on. This stops the use of some DOM API's and means you need to add .ts to imports.

Describe the solution you'd like

It seems that Deno is ready to replace ESLint inside Visual Studio Code, but is just missing something in this extension. Maybe having:

"deno.lint.mode": "Deno / Browser",

Would be a good solution? It could then load the correct types, and deal with the .ts extension issue (somehow) until MicroSoft finally adds it as an option.

Someone can probably think of a much nicer solution, but this could be a good start point for a discussion. Prettier is gone thanks to Deno, would be great to banish more bloat.

@axetroy
Copy link

axetroy commented Sep 7, 2020

This is not difficult, just remove the dependency of deno.enable

But deno_lint is still an implementation feature, I think it is not ready to be fully open, yet.

@David-Else
Copy link
Author

Great news it is easy to do! I think deno lint itself is ready, but if you think the extension implementation needs more work, I really look forward to it in the future.

@kitsonk kitsonk transferred this issue from denoland/vscode_deno Jul 19, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Jul 19, 2021

I moved this from vscode_deno, because not only does this apply for linting in the editor, but elsewhere. Maybe we should consider having lint inspect the ConfigFile compiler options, and seeing what the "lib" value is for those and have that impact what global symbols it has?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants