Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: TtlCache addition to @std/cache #5669

Closed
lionel-rowe opened this issue Aug 9, 2024 · 1 comment · Fixed by #5662
Closed

Suggestion: TtlCache addition to @std/cache #5669

lionel-rowe opened this issue Aug 9, 2024 · 1 comment · Fixed by #5662

Comments

@lionel-rowe
Copy link
Contributor

lionel-rowe commented Aug 9, 2024 •
edited
Loading

Thoughts on adding a TtlCache as well? It occurs to me that LruCache or the default Map aren't much use if the thing you're caching is short-lived data fetched from an API.

Originally posted by @lionel-rowe in #4608 (comment)

Yes, please open a separate issue. I'd like to see more evidence of demand.

Originally posted by @iuioiua in #4608 (comment)
@lionel-rowe lionel-rowe changed the title Thoughts on adding a TtlCache as well? It occurs to me that LruCache or the default Map aren't much use if the thing you're caching is short-lived data fetched from an API. Can open a separate issue and/or PR if needed (if so I'll wait for the current PR to land first) Suggestion: TtlCache addition to @std/cache Aug 9, 2024
@lionel-rowe lionel-rowe mentioned this issue Aug 9, 2024
Merged
@oles
Copy link

oles commented Aug 16, 2024 •
edited
Loading

I really like the addition of cache to @std! Thanks to all who helped land it!

I have used TTL caches in past project, and I would no doubt use @std's instead in future projects. Yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cache/unstable): TtlCache lionel-rowe/std
2 participants
@oles @lionel-rowe