Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(puppeteer): Deprecate Frame constructors & Puppeteer < 3.0.3 #339

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

WilcoFiers
Copy link
Contributor

  • Upgrade to axe-core 4.3.3
  • Call finishRun in a blank page, ensuring environment data exists
  • Deprecate construction with Frame, since Puppeteer has no way to create a new page just from a Frame object
  • Deprecate Puppeteer < 3.0.2, since Page.browser() is not available in those versions

When either deprecated situation occurs, axe-core/puppeteer will be unable to test cross-origin iframes. These are reported as issues in the frame-tested rule.

Comment on lines +55 to +56
const source = fs.readFileSync(require.resolve('axe-core'), 'utf8');
await injectJSSource(frame, source);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make this change, because apparently addScriptTag changes the source of the page, which caused problems with the html property on results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants