Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all "virtual" commons #3896

Open
WilcoFiers opened this issue Jan 26, 2023 · 0 comments
Open

Deprecate all "virtual" commons #3896

WilcoFiers opened this issue Jan 26, 2023 · 0 comments
Labels
core Issues in the core code (lib/core) deprecation tech debt Technical debt related tasks virtual tree
Milestone

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Jan 26, 2023

When we were working on axe-core 3.0 we imagined we'd have different methods for DOM nodes and virtual DOM nodes. The later would be called with methods ending with Virtual. Because of that we ended up with methods like accessibleText and accessibleTextVirtual. We've moved away from this approach more recently. More and more of axe runs exclusively on VirtualNodes. It's faster, safer, lets us normalise more consistently, etc. It's far better. Where DOM nodes are needed we can easily get at them from vNode.actualNode.

So, I would like us to find all xxxVirtual methods, make sure their non-virtual counterpart can accept virtual nodes, then deprecate all those xxVirtual methods, and remove their use from the code base.

@WilcoFiers WilcoFiers added core Issues in the core code (lib/core) tech debt Technical debt related tasks deprecation virtual tree labels Jan 26, 2023
@WilcoFiers WilcoFiers added this to the Axe-core 4.8 milestone Jan 26, 2023
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.8, Axe-core 4.9 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) deprecation tech debt Technical debt related tasks virtual tree
Projects
None yet
Development

No branches or pull requests

1 participant