fix: allow disabling minification from cli #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
approved these changes
May 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 27, 2019
395: fix: allow disabling minification from cli r=ForsakenHarmony a=wardpeet It seems like adding `--compress=false` doesn't work because we never normalize "true"|"false" to a boolean. Now I normalize "false or "0" to a boolean so the compress can be set from the cli. I don't think many people need this feature but it's easy when debugging output. Co-authored-by: Ward Peeters <ward@coding-tech.com> Co-authored-by: Leah <me@hrmny.sh>
Build failed |
|
hmm ye the patch update of async promises broke our tests |
ForsakenHarmony
pushed a commit
that referenced
this pull request
May 27, 2019
ForsakenHarmony
pushed a commit
that referenced
this pull request
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like adding
--compress=falsedoesn't work because we never normalize "true"|"false" to a boolean. Now I normalize "false or "0" to a boolean so the compress can be set from the cli.I don't think many people need this feature but it's easy when debugging output.