Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Swapping out references of ES format to ESM #778

Merged
merged 1 commit into from
May 26, 2021
Merged

docs: Swapping out references of ES format to ESM #778

merged 1 commit into from
May 26, 2021

Conversation

rschristian
Copy link
Collaborator

@rschristian rschristian commented Jan 6, 2021

Summary

Addresses the footer of #775 (comment)

Replaces "es" in the output formats section of the ReadMe + CLI's help with "esm". The format is otherwise always referred to as "ESM" or "ES Modules" so I agree that's a fair change to make.

Note: There's a few unrelated changes caused by the prettier pre-commit hook. I'd normally revert the unrelated changes but I figure the hook is there to be used.

@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2021

⚠️ No Changeset found

Latest commit: 5ca8d74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We have these aliased anyway so its nice to standardize. I believe Rollup also allows both, though they have es as the default.

@rschristian
Copy link
Collaborator Author

Ah, that makes sense! I noticed that esm gets converted to es after checking that both were supported but wasn't sure of the reason for it.

@rschristian rschristian changed the title refactor: Swapping out references of ES format to ESM docs: Swapping out references of ES format to ESM May 22, 2021
@ForsakenHarmony ForsakenHarmony merged commit 89ab03d into developit:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants