Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: devholic/k3d Loading
base: main
Choose a base ref
...
head repository: devholic/k3d Loading
compare: cluster-list-consistent-output-patch
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 26 files changed
  • 1 contributor

Commits on Jun 24, 2022

  1. fix: print consistent output for list clusters 

    Currently, `k3d cluster list` or `k3d cluster get` prints differently
per output option (`json` / `yaml`). This behavior may break
interoperability and can make users hard to figure out the difference
between outputs.

This commit fixes this issue by using the `Marshal` function of
`sigs.k8s.io/yaml`, which converts the json-encoded struct to yaml.

Signed-off-by: Sunghoon Kang <hoon@akuity.io>
    @devholic
    devholic committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    2fc798f View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. refactor: replace gopkg.in/yaml.v2 with sigs.k8s.io/yaml 

    k3d-io#1094 (comment)

Signed-off-by: Sunghoon Kang <hoon@akuity.io>
    @devholic
    devholic committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    48221ce View commit details
    Browse the repository at this point in the history

  2. refactor: merge field's yaml tag into json tag 

    Signed-off-by: Sunghoon Kang <hoon@akuity.io>
    @devholic
    devholic committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    b11130a View commit details
    Browse the repository at this point in the history

  3. fix: use gopkg.in/yaml.v2 to split yaml 

    Signed-off-by: Sunghoon Kang <hoon@akuity.io>
    @devholic
    devholic committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    08fcc7d View commit details
    Browse the repository at this point in the history

  4. fix: fix type of ConfigMap data 

    Signed-off-by: Sunghoon Kang <hoon@akuity.io>
    @devholic
    devholic committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    1bf9341 View commit details
    Browse the repository at this point in the history
Loading