Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imports should use fully qualified repo #2

Closed
DocSavage opened this issue Jan 21, 2014 · 4 comments
Closed

imports should use fully qualified repo #2

DocSavage opened this issue Jan 21, 2014 · 4 comments

Comments

@DocSavage
Copy link

We've done this in our fork (can't really do a pull request for this kind of change). Suggest you replace all the import "drmaa" in your subdirectories with the fully qualified repo URL, e.g., import "github.com/dgruber/drmaa".

@kisielk
Copy link

kisielk commented Jan 21, 2014

+1 to this. By the way, you can do it in your fork if you keep your import paths intact. You can always clone your fork to $GOPATH/src/github.com/dgruber/drmaa regardless of where you are actually hosting it. That's pretty standard practice when forking / sending PRs for Go code.

@DocSavage
Copy link
Author

I'll try that for the next PRs :)

@DocSavage DocSavage reopened this Jan 21, 2014
@dgruber
Copy link
Owner

dgruber commented Feb 18, 2014

Sorry, for the late response. I corrected the imports and also the README, so that the users should check out in src/github.com/dgruber directory. Does this fix your issues?

@dgruber
Copy link
Owner

dgruber commented Feb 18, 2014

I'm closing the issue now, feel free to re-open or create a new one if you have any issues / enhancements. Thanks for using!

@dgruber dgruber closed this as completed Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants