fix(release): add comment to why we read json manually

packages/utils/src/cmds/release.js

@@ -1,6 +1,6 @@
-const { existsSync } = require('fs')
 const path = require('path')
 const { reporter } = require('@dhis2/cli-helpers-engine')
+const { existsSync } = require('fs-extra')
 const semanticRelease = require('semantic-release')
 const getWorkspacePackages = require('../support/getWorkspacePackages')
 
@@ -65,8 +65,6 @@ function publisher(target = '', packages) {
 }
 
 const handler = async ({ publish }) => {
-    // set up the plugins and filter out any undefined elements
-
     const rootPackageFile = path.join(process.cwd(), 'package.json')
     const packages = [
         rootPackageFile,

packages/utils/src/support/semantic-release-app-hub.js

@@ -10,7 +10,19 @@ exports.verifyConditions = (config, context) => {
     const { pkgRoot } = config
     const { env } = context
 
+    // make sure to read the file from disk since it will have changed
+    // in a previous external step (semantic-release/npm), and if we use
+    // require here we get a cached result.
     const packagePath = fs.readJsonSync(pkgRoot, 'package.json')
+
+    if (!fs.existsSync(packagePath)) {
+        throw new SemanticReleaseError(
+            `Failed to locate package.json file, does it exist in ${pkgRoot}?`,
+            'EMISSINGPACKAGE',
+            'package.json is necessary to automatically publish to the App Hub'
+        )
+    }
+
     const configPath = path.join(pkgRoot, 'd2.config.js')
 
     if (!fs.existsSync(configPath)) {
@@ -21,14 +33,6 @@ exports.verifyConditions = (config, context) => {
         )
     }
 
-    if (!fs.existsSync(packagePath)) {
-        throw new SemanticReleaseError(
-            `Failed to locate package.json file, does it exist in ${pkgRoot}?`,
-            'EMISSINGPACKAGE',
-            'package.json is necessary to automatically publish to the App Hub'
-        )
-    }
-
     const d2Config = require(configPath)
 
     if (d2Config.type === 'lib') {
@@ -72,6 +76,10 @@ exports.publish = async (config, context) => {
     const { env, nextRelease } = context
 
     const packagePath = path.join(pkgRoot, 'package.json')
+
+    // make sure to read the file from disk since it will have changed
+    // in a previous external step (semantic-release/npm), and if we use
+    // require here we get a cached result.
     const pkg = fs.readJsonSync(packagePath)
 
     if (semver.lt(pkg.version, nextRelease.version)) {