Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add neutral link variant in Figma #2098

Closed
Tracked by #2097
, #2086
...
Febakke opened this issue Jun 4, 2024 · 3 comments
Closed
Tracked by #2097
, #2086
...

Add neutral link variant in Figma #2098

Febakke opened this issue Jun 4, 2024 · 3 comments
Assignees
@Febakke
Labels
🎨 figma Everything related to changes in Figma

Comments

@Febakke
Copy link
Member

Febakke commented Jun 4, 2024

No description provided.

@Febakke Febakke mentioned this issue Jun 4, 2024
Closed
@Febakke Febakke changed the title Add variant in Figma Add neutral link variant in Figma Jun 4, 2024
@Febakke Febakke added the 🎨 figma Everything related to changes in Figma label Jun 4, 2024
@Febakke Febakke self-assigned this Jun 4, 2024
@Febakke Febakke mentioned this issue Jun 4, 2024
Closed
@Febakke
Copy link
Member Author

Febakke commented Jun 4, 2024

Adding the same color tokens as the accent button gives grey links. Could they be confused with disabled links? @Thuneer

Image

@Febakke
Copy link
Member Author

Febakke commented Jun 4, 2024

Solution:
Swap neutral-text-subtleand neutral-text-default on the neutral variants

Skjermbilde 2024-06-04 kl 14 15 58

@mimarz
Copy link
Collaborator

mimarz commented Jun 11, 2024

Reviewed by @mrosvik

@mimarz mimarz closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Febakke Febakke

Labels
🎨 figma Everything related to changes in Figma
Projects
Team Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mimarz @Febakke