Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't trigger when needed #15

Closed
joshribakoff opened this issue May 2, 2014 · 3 comments
Closed

Doesn't trigger when needed #15

joshribakoff opened this issue May 2, 2014 · 3 comments

Comments

@joshribakoff
Copy link

Excellent plugin, found an issue though...

1 - resize browser really small, so only 1-2 images are visible
2 - open a new tab & goto google
3 - maximize browser
4 - go back to original tab

Actual results - since the browser is now bigger, more images are shown, but blazy doesn't detect that more images are now visible. Although scrolling at least 1px triggers them to load

Expected results - blazy should not only fire on scroll event, but on browser resize, or when a tab becomes active (or at least fire an interval every few seconds to compare the current browser size to the last known size)

@oskarrough
Copy link

Seconded.

Triggering on page visibility doesn't seem to be that well supported (http://stackoverflow.com/a/12186061/273406) and firing intervals continously isn't optimal. Although it seems Blazy is already triggering on window resize.

@dinbror
Copy link
Owner

dinbror commented May 4, 2014

Fixed in v. 1.2.2. Thanks for reporting

@dinbror dinbror closed this as completed May 4, 2014
@joshribakoff
Copy link
Author

Thanks I applied the patch from ae11c6b and I can confirm it solves the issue. Greatly appreciated! FYI you can mention the issue number (15) following the hash sign (#) in your commit message, which will place a link from the issue on GitHub to the changeset, which makes it easier for people to find patches when viewing the issue on GitHub :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants