Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove None selection by default or expose a param to toggle it #4

Open
gnikoloff opened this issue Feb 17, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@gnikoloff
Copy link

Nice plugin, works perfectly, except the default "None" selection. The docs don't say much on how to remove it?

Right now I hide it with CSS, but would be really nice to have control over it.

Thanks for the plugin!

@donmccurdy donmccurdy added the enhancement New feature or request label Feb 20, 2022
@donmccurdy
Copy link
Owner

Hi, great suggestion @gnikoloff! The project I built this for always needed a 'None' option, but I agree that some way of omitting it would probably be good. Either:

  • (A) an API option that just removes it and makes the input non-nullable
  • (B) an explicit way to add the option, e.g. value: null, and testing that it works correctly

I'm not working on this project actively right now, but would be glad to review PRs for either of the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants