Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create story for updating the Helix api generated client code #124

Closed
alexperovich opened this issue Apr 17, 2018 · 9 comments
Closed

Create story for updating the Helix api generated client code #124

alexperovich opened this issue Apr 17, 2018 · 9 comments
Assignees

Comments

@alexperovich
Copy link
Member

The Helix Api Client code is currently generated by https://github.com/Azure/autorest
We need to figure out what the correct story is for either

  • Updating the checked in code when new changes are deployed to the helix api, or
  • Generating the code on-the-fly as part of the build of arcade

I am partial to leaving the code checked in and making something that will run the generator when new APIs are available to avoid adding node/npm to the build of arcade.

@markwilkie
Copy link
Member

I am partial to leaving the code checked in and making something that will run the generator when new APIs are available to avoid adding node/npm to the build of arcade.

Fine, this will work. However, before closing, @alexperovich, can you get a tracking issue to document please?

@alexperovich
Copy link
Member Author

Is this issue not the tracking issue? Am I missing something?

@markwilkie
Copy link
Member

@alexperovich - fair, grin. I guess I meant a documentation specific issue. But to your point, this one works fine for that.

@markwilkie
Copy link
Member

Follow up with Alex as this was being poked on already

@jcagme
Copy link
Contributor

jcagme commented Oct 22, 2018

Is this something you own @alexperovich ?

@alexperovich
Copy link
Member Author

I have things in the pipe for this, its just not super high priority. If we need the current code to get updated I can manually update it.

@jcagme
Copy link
Contributor

jcagme commented Oct 23, 2018

Asking more to know who to assign this issue. Can this be assigned to you?

@alexperovich
Copy link
Member Author

yes

@alexperovich
Copy link
Member Author

This will be solved as part of dotnet/core-eng#3728. For that work we need generated clients for both repro-tool and BAR/Maestro, we will get Helix for free when that is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants